Typing in search bar in Private tab does not give "Search with <search engine>" tag

[prakharb5]

Description

When opening a new private tab, i go to the search bar on top and type something, I dont get the normal "Search with (search engine)" tag. Instead, it is considered as a website. Doing the same with 2 words and pressing enter crashes the browser

Steps to Reproduce

1. Open a new private window
2. Type 2 words in the search bar and observe the results.
3. Press enter to see the crash.

Actual result:

Expected result:

The browser should identify this as a search term and enable the search engine to be used.
The crash should not happen.

Reproduces how often:

Easily produced when following above steps.

Brave version (brave://version info)

Brave	1.17.3 Chromium: 86.0.4240.55 (Official Build) nightly (64-bit)
Revision	a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS	Windows 10 OS Version 2009 (Build 19042.541)

Version/Channel Information:

• Can you reproduce this issue with the current release? YES
• Can you reproduce this issue with the beta channel? YES
• Can you reproduce this issue with the nightly channel? YES

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? NO
• Does the issue resolve itself when disabling Brave Rewards? NO
• Is the issue reproducible on the latest version of Chrome? YES

Miscellaneous Information:

Nothing as of now.

[DevBefell]

I have the same problem, from what I experience, if you type, for example "Hello World", it will crash brave all the time because there is a "space", I think it is because, as you said, not using the search engine, but trying to use whatever that is inputted as an link to a website, which I suppose is not intended.

[prakharb5]

@PyICoder in which version did you face this issue? I would like to know.

[DevBefell]

Version 1.15.72 Chromium: 86.0.4240.75 (Official Build) (64-bit), the latest one I think, from About Brave page.

[prakharb5]

Ok, so I think this issue is present in all Brave versions.

[prakharb5]

When will this issue be fixed?

[DevBefell]

I do not know, but I hope soon, because I use private alot.

[ShankarBUS]

Could anyone fix this soon?
It's too annoying and irritating!

[rebron]

@Cyberdroid1 Sorry for the delay, we need some more info on this. I'm not able to reproduce given the steps you provided.
I'm in on our latest 1.18.70 on Windows and typing in two search terms in the url bar in private window gives me results either in Google search or Duck Duck Go search, didn't try any other search engines. It shows as two words - Google search or two words - DuckDuckGo Search And no crash. What search engine are you using?

Second clarification:
Search with is an open search feature that's specific to certain websites like ebay, cnet, others that implemented the following https://developer.mozilla.org/en-US/docs/Web/OpenSearch. The search engine will be added here: brave://settings/searchEngines and then invoked when typing in the search engine's address (the default keyword) and pressing Tab. Is that what you mean? That should work in both normal windows and private windows.

@PyICoder Hello World is giving me the results below on both WIndows and mac. Are you still seeing a crash?

[prakharb5]

Unfortunately, the bug is still there.

I have recorded a video for the same.

Video.zip
Have a look.

Strangely, this bug is not present on macOS though (Brave Stable version).

[DevBefell]

Same for me, it still crashes and still have the bug:
Brave Version:

Video:

[rebron]

cc: @kjozwiak Can you reproduce?

[prakharb5]

I have stopped receiving this error now.
Looks like it might be fixed now.

[DevBefell]

It still happens to me, I did update, but I did figure out why it happens, it seems that when the DuckDuckGo Privacy Essentials extension controls the Search engine, and it Allowed in Private, the issue appears. To fix, all I have to do is disable the extension from private.

[prakharb5]

Oh, is that so? I had removed duckduckgo extension some days back, and have not been facing this issue from then, but I couldn't relate the 2 incidents.

Duckduckgo extension seems sus now.

[DevBefell]

I would not say sus, but in need of some fixes.

[kjozwiak]

It still happens to me, I did update, but I did figure out why it happens, it seems that when the DuckDuckGo Privacy Essentials extension controls the Search engine, and it Allowed in Private, the issue appears. To fix, all I have to do is disable the extension from private.

I was going to ask what extensions you guys are using as it sounds similar to what was reported via #10549.

I managed to reproduce the issue using DDG Privacy Essentials once I switched/enabled Allow in private via brave://extensions.

Same thing happens with the following:

Qwant

• https://chrome.google.com/webstore/detail/qwant-for-chrome/hnlkiofnhhoahaiimdicppgemmmomijo

Ecosia

@Cyberdroid1 @PyICoder if you agree that this is the same issue, we can close this one off and use #10549. However, we can mention that another case/issue was reported and link to this issue as well 👍

[prakharb5]

I feel it is the same issue. You can close this one :)

Both are reporting the same bug, so I feel we should go with the one you referred to.

[rebron]

Closing as dupe of #10549. In #10549 looks like this is something the Extension dev should address.