Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] some brave:// pages are missing the navigation bar - C86 regression #11937

Closed
LaurenWags opened this issue Sep 30, 2020 · 3 comments · Fixed by brave/brave-core#6736

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Sep 30, 2020

Description

Certain pages like brave://rewards and brave://wallet have the navigation bar at the top of the page (along with settings, history, bookmarks, downloads) in 1.14.x/C85.

This nav bar is missing with 1.15.x/C86 on brave specific pages (rewards and wallet). Other pages (settings, history, downloads, bookmarks) still have it.

Steps to Reproduce

  1. Using C86 version of 1.15.x open brave://settings, see nav bar at top
  2. Click on Rewards or Wallet from nav bar

Actual result:

Screen Shot 2020-09-30 at 12 09 49 PM

Expected result:

Screen Shot 2020-09-30 at 12 09 12 PM

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.15.68 Chromium: 86.0.4240.55 (Official Build) dev (x86_64)
Revision a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a 1.14.x, yes 1.15.x
  • Can you reproduce this issue with the beta channel? yes 1.16.x (1.16.47)
  • Can you reproduce this issue with the nightly channel? yes, 1.17.x (1.17.3)

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @mkarolin @bsclifton @rebron @brave/legacy_qa

@btlechowski
Copy link

Reproduced on Ubuntu

Brave 1.16.46 Chromium: 86.0.4240.55 (Official Build) nightly (64-bit)
Revision a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS Ubuntu 18.04 LTS

image

@GeetaSarvadnya
Copy link

Reproduced in Windows 10 x64 - 1.15.65 Chromium: 86.0.4240.55

image
image

@LaurenWags
Copy link
Member Author

LaurenWags commented Oct 1, 2020

Verified passed with

Brave | 1.15.69 Chromium: 86.0.4240.55 (Official Build) (x86_64)
-- | --
Revision | a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS | macOS Version 10.14.6 (Build 18G3020)

Verified STR from description

Screen Shot 2020-10-01 at 10 23 36 AM

Additionally, verified the pages mentioned in brave/brave-core#6736

  • Confirmed brave://rewards loaded and I could join from this page
  • Confirmed able to claim UGP grant on brave://rewards, navigate to a site, do a one time tip and set up a recurring tip
  • Confirmed brave://adblock loads and I was able to select a filter. Confirmed component for filter was downloaded and displayed on brave://components.
  • Confirmed could enable IPFS Companion in brave://settings. Confirmed extension was downloaded and displayed on brave://extensions.
  • Confirmed able to submit a site (via "Report a broken site" button on shields) for webcompat.

Verification passed on


Brave | 1.15.69 Chromium: 86.0.4240.55 (Official Build) (64-bit)
-- | --
Revision | a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS | Windows 10 OS Version 1903 (Build 18362.1016)


  • Verified STR from description

brave://rewards
image
image

brave://wallet
image

Additionally, verified the pages mentioned in brave/brave-core#6736

  • Confirmed brave://rewards loaded and I could join from this page
  • Confirmed able to claim UGP grant on brave://rewards, navigate to a site, do a one time tip and set up a recurring tip
  • Confirmed brave://adblock loads and I was able to select a filter. Confirmed component for filter was downloaded and displayed on brave://components.
  • Confirmed could enable IPFS Companion in brave://settings. Confirmed extension was downloaded and displayed on brave://extensions.
  • Confirmed able to submit a site (via "Report a broken site" button on shields) for webcompat.

  • Verified STR from description

brave://rewards
image

brave://wallet
image

Additionally, verified the pages mentioned in brave/brave-core#6736

  • Confirmed brave://rewards loaded and I could join from this page
  • Confirmed able to claim UGP grant on brave://rewards, navigate to a site, do a one time tip and set up a recurring tip
  • Confirmed brave://adblock loads and I was able to select a filter. Confirmed component for filter was downloaded and displayed on brave://components.
  • Confirmed could enable IPFS Companion in brave://settings. Confirmed extension was downloaded and displayed on brave://extensions.
  • Confirmed able to submit a site (via "Report a broken site" button on shields) for webcompat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment