Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enabling BAT logo position problem #11801

Closed
NejcZdovc opened this issue Sep 22, 2020 · 1 comment · Fixed by brave/brave-core#6686
Closed

Re-enabling BAT logo position problem #11801

NejcZdovc opened this issue Sep 22, 2020 · 1 comment · Fixed by brave/brave-core#6686

Comments

@NejcZdovc
Copy link
Contributor

Description

BAT logo is cut if you toggle hide rewards button. It's fixed it you switch tabs for example.

Steps to Reproduce

  1. Enable rewards
  2. Disable rewards
  3. Go to brave://settings/appearance
  4. Click on hide rewards button (make sure it hides)
  5. Click on hide rewards button again

Actual result:

Button appears again, but it's partially cut out
image

Expected result:

image

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 30, 2020

Verification passed on

Brave | 1.16.46 Chromium: 86.0.4240.55 (Official Build) nightly (64-bit)
-- | --
Revision | a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

  • Verified the STR from the description
  • Ensured that enable and disable Hide Brave Rewards button doesn't change the BAT logo position

Verified passed with

Brave | 1.16.50 Chromium: 86.0.4240.55 (Official Build) dev (x86_64)
-- | --
Revision | a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS | macOS Version 10.14.6 (Build 18G3020)
  • Verified the STR from the description
  • Ensured that enable and disable Hide Brave Rewards button doesn't change the BAT logo position

Verification passed on

Brave 1.16.50 Chromium: 86.0.4240.55 (Official Build) dev (x86_64)
Revision a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS Ubuntu 18.04 LTS
  • Verified the STR from the description
  • Ensured that enable and disable Hide Brave Rewards button doesn't change the BAT logo position

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment