Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Auto-contribute doesn't process if more than four publishers are on the list #10834

Closed
NejcZdovc opened this issue Jul 21, 2020 · 1 comment · Fixed by brave/brave-core#6164

Comments

@NejcZdovc
Copy link
Contributor

Description

Right now we have hard limit on 3 retries per step. Because when we are sending out suggestions we go through retry logic it will automatically finish after 4 publishers are process as this equals to 3 retries per step. We need to remove this limit for step STEP_PREPARE as this is expected to go over. We need to think over how to distinguish between valid retry and failed retry for this step.

Steps to Reproduce

  1. enable rewards
  2. add 6 verified publishers to AC table
  3. trigger AC

Actual result:

Only 4 publishers are processed

Expected result:

All publishers should be processed.

Reproduces how often:

easily

Brave version (brave://version info)

this was introduced with version 1.10

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 30, 2020

Verification passed on


Brave | 1.12.105 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | Windows 10 OS Version 1903 (Build 18362.959)

  • Verified description from the issue and ensured that AC is processed for 6 publishers
    image
    image

image


Verified passed with

Brave | 1.12.105 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | macOS Version 10.14.6 (Build 18G3020)
  • Verified STR from description
  • Confirmed AC completed for 6 publishers in the list:

Screen Shot 2020-08-04 at 10 44 34 AM


Verification passed on

Brave 1.12.107 Chromium: 84.0.4147.105 (Official Build) (64-bit)
Revision a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS Ubuntu 18.04 LTS
  • Verified STR from description
  • Confirmed AC completed for 5 publishers in the list:
    image

@rebron rebron changed the title [Desktop] AC doesn't completed if you have more then 4 publisher in the list [Desktop] Auto-contribute doesn't process if more than four publishers are on the list Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants