Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Fingerprinting label is blank on the "Learn more" view of shields #10670

Closed
LaurenWags opened this issue Jul 9, 2020 · 1 comment · Fixed by brave/brave-core#6060
Assignees
Labels
feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields feature/shields The overall Shields feature in Brave. OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes regression release-notes/exclude

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #9194

If you are on a site while the simple shields view is being used, you have a link to "Learn more". If you click on this link, you're taken to a read only view of the shields. On this read only view, the new FP labeling is not displayed.

Steps to Reproduce

  1. Navigate to a site
  2. Click on shields
  3. If not already on simple view, click on link for Simple View
  4. Click on "Learn more" link in the middle of the panel.

Actual result:

At the bottom of the panel, FP setting is blank
Screen Shot 2020-07-09 at 8 01 35 AM
Screen Shot 2020-07-09 at 8 04 30 AM

Expected result:

Should show FP setting like it does in 1.10.97:
Screen Shot 2020-07-09 at 8 10 01 AM

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.11.92 Chromium: 84.0.4147.68 (Official Build) dev (64-bit)
Revision e7b7234037639b407e69c5428c891ce018cd6c0d-refs/branch-heads/4147@{#772}
OS macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no
  • Can you reproduce this issue with the beta channel? yes (1.11.x)
  • Can you reproduce this issue with the dev channel? yes (1.11.x)
  • Can you reproduce this issue with the nightly channel? unsure, probably

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @pes10k @rebron @brave/legacy_qa

@LaurenWags LaurenWags added feature/shields The overall Shields feature in Brave. feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields QA/Yes regression OS/Desktop labels Jul 9, 2020
@LaurenWags LaurenWags changed the title [Desktop] Fingerprinting label changes do not show on the "Learn more" view of shields [Desktop] Fingerprinting label is blank on the "Learn more" view of shields Jul 9, 2020
@simonhong simonhong self-assigned this Jul 9, 2020
@kjozwiak kjozwiak added this to the 1.12.x - Beta milestone Jul 22, 2020
@LaurenWags
Copy link
Member Author

LaurenWags commented Jul 23, 2020

Verified passed with

Brave | 1.12.99 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | macOS Version 10.14.6 (Build 18G3020)
  • Verified STR from description

Screen Shot 2020-07-23 at 11 16 54 AM

Screen Shot 2020-07-23 at 11 18 16 AM


Verification passed on


Brave | 1.12.99 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | Windows 10 OS Version 1903 (Build 18362.959)

  • Verified STR from the description
    image
    image

Verification passed on

Brave 1.12.102 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS Ubuntu 18.04 LTS
  • Verified test plan from the description
    image
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields feature/shields The overall Shields feature in Brave. OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes regression release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants