Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] usage ping not sent for 1.11.92 #10610

Closed
LaurenWags opened this issue Jul 8, 2020 · 4 comments
Closed

[Desktop] usage ping not sent for 1.11.92 #10610

LaurenWags opened this issue Jul 8, 2020 · 4 comments

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Jul 8, 2020

Description

Found while testing #10061 and #10230

1.11.92 (Dev) is not sending a usage ping, but 1.11.90 does.

Steps to Reproduce

  1. Open tool like Charles to watch network traffic
  2. Launch 1.11.92 with a clean profile
  3. Look for usage ping

Actual result:

No usage ping
Screen Shot 2020-07-08 at 9 42 06 AM

Expected result:

Should be a usage ping like there is with 1.11.90 (below was taken with a clean profile)
Screen Shot 2020-07-08 at 9 39 59 AM

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.11.92 Chromium: 84.0.4147.68 (Official Build) dev (64-bit)
Revision e7b7234037639b407e69c5428c891ce018cd6c0d-refs/branch-heads/4147@{#772}
OS macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no, works with 1.10.97
  • Can you reproduce this issue with the beta channel? unsure
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? no, works with 1.12.79

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @keur @aekeus @rebron @brave/legacy_qa

@kkuehlz
Copy link
Contributor

kkuehlz commented Jul 8, 2020

QA tested this on 1.12 and the issue is not present. Safe to assume there is some code the not included in the uplift needs to be present. Let's just revert brave/brave-core#5957 and wait until 1.12 for these changes. Thank you again QA team.

@kjozwiak
Copy link
Member

kjozwiak commented Jul 8, 2020

Just some more context, also reproduced using the following build:

Brave | 1.11.92 Chromium: 84.0.4147.68 (Official Build) dev (64-bit)
-- | --
Revision | e7b7234037639b407e69c5428c891ce018cd6c0d-refs/branch-heads/4147@{#772}
OS | macOS Version 10.15.5 (Build 19F101)

I'm not seeing any usage pings under https://laptop-updates.brave.com. As per @keur, this is working on 1.12.x and was QA'd via brave/brave-core#5720 (comment) and brave/brave-core#5823 (comment). @LaurenWags also confirmed that it's working on 1.12.x.

@kjozwiak
Copy link
Member

kjozwiak commented Jul 8, 2020

Reverted via brave/brave-core#6032. W should recheck to make sure pings are still working once we get a new 1.11.x 👍

@LaurenWags
Copy link
Member Author

LaurenWags commented Jul 10, 2020

Verified passed with

Brave | 1.11.94 Chromium: 84.0.4147.85 (Official Build) (64-bit)
-- | --
Revision | e20c13e958edc3707db3d26d513780a7f6331a4b-refs/branch-heads/4147@{#837}
OS | macOS Version 10.14.6 (Build 18G3020)
  • Verified STR from description

Screen Shot 2020-07-10 at 7 57 21 AM

Verification passed on


Brave | 1.11.94 Chromium: 84.0.4147.85 (Official Build) (64-bit)
-- | --
Revision | e20c13e958edc3707db3d26d513780a7f6331a4b-refs/branch-heads/4147@{#837}
OS | Windows 10 OS Version 1903 (Build 18362.900)

image


Verification passed on

Brave 1.11.94 Chromium: 84.0.4147.85 (Official Build) (64-bit)
Revision e20c13e958edc3707db3d26d513780a7f6331a4b-refs/branch-heads/4147@{#837}
OS Ubuntu 18.04 LTS

Verified test plan from the description

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants