Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different settings page are launched for Tor window #10567

Closed
simonhong opened this issue Jul 6, 2020 · 2 comments
Closed

Different settings page are launched for Tor window #10567

simonhong opened this issue Jul 6, 2020 · 2 comments

Comments

@simonhong
Copy link
Member

simonhong commented Jul 6, 2020

Description

Tor window opens different settings page depends on how user opens settings page.
With app menu in Tor window, Normal profile's settings page is opened.
With shortcut(ex, cmd + ,), Tor profile's settings page is opened.
I think Tor window always should use normal profile's settings page instead of its own because Tor window is based on private profile. cc: @darkdh @yrliou

Steps to Reproduce

  1. Launch browser and open Tor window
  2. In Tor's NTP, open settings page via app menu
  3. Check normal profile's settings page is opened
  4. In Tor's NTP, open settings page via app shortcut
  5. Check different settings page is opened

Actual result:

Different settings page are opened.

Expected result:

Same settings page should be used.
keyboard shortcut "cmd + ," should go to normal brave://settings page

Reproduces how often:

Easily

Brave version (brave://version info)

Version 1.12.72 Chromium: 84.0.4147.68 (Official Build) nightly (64-bit)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@rebron rebron added needs-more-info The report requires more detail before we can decide what to do with this issue. feature/tor feature/global-settings Settings at browser level independent of shields settings labels Aug 31, 2020
@rebron rebron assigned rebron and unassigned rebron Aug 31, 2020
@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". and removed needs-more-info The report requires more detail before we can decide what to do with this issue. labels Sep 2, 2020
@darkdh
Copy link
Member

darkdh commented Dec 4, 2020

This is fixed by brave/brave-core#7069

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 22, 2020

Verification passed on


Brave | 1.19.64 Chromium: 87.0.4280.101 (Official Build) dev (64-bit)
-- | --
Revision | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS | Windows 10 OS Version 2004 (Build 19041.685)

Verified the test plan from brave/brave-core#7069
Verified the STR from the description


Verification passed on

Brave 1.19.73 Chromium: 87.0.4280.101 (Official Build) dev (64-bit)
Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS Ubuntu 18.04 LTS

Verified the test plan from brave/brave-core#7069
Verified the STR from the description


Verified passed with

Brave | 1.19.79 Chromium: 87.0.4280.141 (Official Build) dev (x86_64)
-- | --
Revision | 9f05d1d9ee7483a73e9fe91ddcb8274ebcec9d7f-refs/branch-heads/4280@{#2007}
OS | macOS Version 10.15.7 (Build 19H15)

Verified STR from description.
Additional test notes can be found under #12429 (comment).

@rebron rebron changed the title [Desktop] Different settings page are launched for Tor window Different settings page are launched for Tor window Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants