Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Remove Brave Account branding for password storage #10469

Closed
srirambv opened this issue Jun 25, 2020 · 5 comments · Fixed by brave/brave-core#6317
Closed

[Desktop] Remove Brave Account branding for password storage #10469

srirambv opened this issue Jun 25, 2020 · 5 comments · Fixed by brave/brave-core#6317

Comments

@srirambv
Copy link
Contributor

srirambv commented Jun 25, 2020

Description

Remove Brave Account branding for password storage

Steps to Reproduce

  1. Enable Sync on nightly
  2. Enable passwords in Sync Settings
  3. Create an account on a page, suggests password to store which has Brave Account branding
  4. Save Password modal also has Brave Account branding

Actual result:

image
image

Expected result:

No Brave Account branding anywhere in the product.
Replace Brave Account with Brave sync chain

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.12.45 Chromium: 83.0.4103.116 (Official Build) nightly (64-bit)
Revision 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{# 716}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the dev channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @darkdh @rebron @bsclifton @jsecretan @brave/legacy_qa

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jun 30, 2020
@rebron rebron self-assigned this Jun 30, 2020
@jsecretan
Copy link

So @rebron is Brave Sync Chain ok alternative text here?

@rebron
Copy link
Collaborator

rebron commented Jul 28, 2020

Alternative text of Brave sync chain to replace is good here.

@rebron
Copy link
Collaborator

rebron commented Jul 28, 2020

cc: @darkdh

@rebron
Copy link
Collaborator

rebron commented Aug 10, 2020

Checked that this is working in one place, but there are several locations for this fix that's we'll want to check.

Brave 1.14.27 Chromium: 85.0.4183.59 (Official Build) nightly (64-bit)
Revision 7cc9a5ee672625c38427a839cb1b15efd3128084-refs/branch-heads/4183@{#1216}
OS macOS Version 10.16 (Build 20A5343i)

Looks good:

Screen Shot 2020-08-07 at 8 51 36 AM

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 18, 2020

Verification passed on


Brave | 1.13.73 Chromium: 84.0.4147.125 (Official Build) dev (64-bit)
-- | --
Revision | d0784639447f2e10d32ebaf9861092b20cfde286-refs/branch-heads/4147@{#1059}
OS | Windows 10 OS Version 1903 (Build 18362.1016)


image

image


Verified passed with

Brave | 1.13.76 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
-- | --
Revision | 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS | macOS Version 10.14.6 (Build 18G3020)

Screen Shot 2020-08-18 at 9 50 51 AM

Screen Shot 2020-08-18 at 10 17 30 AM


Verification passed on

Brave 1.13.77 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
Revision 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS Ubuntu 18.04 LTS

Verified test plan from the description

image
Passwords are saved in your Brave sync chain so you can use them on any device is not translated
image
Logged #11341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment