Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Remove cookie exceptions for android #10455

Closed
jumde opened this issue Jun 24, 2020 · 4 comments
Closed

[Android] Remove cookie exceptions for android #10455

jumde opened this issue Jun 24, 2020 · 4 comments
Labels
closed/duplicate Issue has already been reported OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. webcompat/not-shields-related Sites are breaking because of something other than Shields.
Milestone
Closed / Dupe / I...

Comments

@jumde
Copy link
Contributor

jumde commented Jun 24, 2020

Description

Android doesn't have the socialMediaBlocking toggle to disable cookie exceptions. Disable cookie exceptions till socialMediaBlocking is enabled.
@jumde jumde added OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. webcompat/not-shields-related Sites are breaking because of something other than Shields. labels Jun 24, 2020
@bsclifton
Copy link
Member

Ticket to track adding Social Media Blocking functionality:
#9536

@bsclifton bsclifton added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jun 24, 2020
@bsclifton
Copy link
Member

Bumping to P2 per recommendation by @pes10k as there is no way to disable this functionality on Android at the moment

@jumde jumde mentioned this issue Oct 19, 2020
Closed
33 tasks
@jumde
Copy link
Contributor Author

jumde commented Oct 19, 2020

With this change we need to verify if:

#5869
#5075
#9852
#10367

are working correctly.

@jumde
Copy link
Contributor Author

jumde commented Oct 20, 2020

Will be addressed by: #9536

@jumde jumde closed this as completed Oct 20, 2020
@jumde jumde added this to the Closed / Dupe / Invalid milestone Oct 20, 2020
@jumde jumde added the closed/duplicate Issue has already been reported label Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/duplicate Issue has already been reported OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. webcompat/not-shields-related Sites are breaking because of something other than Shields.
Projects
None yet
Milestone
Closed / Dupe / Invalid
Development

Successfully merging a pull request may close this issue.

[WIP] Fix #10455: Cookie exceptions should not be added to android brave/brave-core
2 participants
@jumde @bsclifton