Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] When setting is enabled, show bookmarks bar on NTP even if there aren't any bookmarks #10450

Closed
LaurenWags opened this issue Jun 24, 2020 · 2 comments · Fixed by brave/brave-core#5941

Comments

@LaurenWags
Copy link
Member

Description

Follow up to #3568

In the issue above, we added informational/instructional text on the bookmarks bar to prompt users to import bookmarks. However, we don't show the bookmarks bar on NTP without any bookmarks (noted in #3568 (comment)).

Per discussion with @rebron since Always show bookmarks on New Tab page is the default setting, we should show this informational text on the bookmarks bar on the NTP.

Steps to Reproduce

  1. Clean profile 1.11.x
  2. You don't instructional text on the bookmarks bar on the welcome screen (because Show Bookmarks is toggled off per default settings). This is fine.
  3. Open NTP.

Actual result:

No bookmarks bar is displayed because there aren't any bookmarks

Expected result:

Bookmarks bar should be displayed with the instructional text from #3568

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.11.75 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
Revision 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a, text only added with 1.11.x
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @rebron @simonhong

@LaurenWags
Copy link
Member Author

LaurenWags commented Jul 17, 2020

Verified passed with

Brave | 1.12.92 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | macOS Version 10.14.6 (Build 18G3020)
  • Verified STR from description

Screen Shot 2020-07-17 at 8 39 43 AM


Verification passed on


Brave | 1.12.94 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | Windows 10 OS Version 1903 (Build 18362.959)


  • Verified STR from the description

image

Encountered #10798

Verification passed on

Brave 1.12.99 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS Ubuntu 18.04 LTS
  • Verified STR from the description

image

@kjozwiak
Copy link
Member

Import bookmarks now.. doesn't appear as a link when using the default light theme. Created #10798.

Screen Shot 2020-07-17 at 11 40 13 PM

@rebron rebron changed the title [Desktop] when setting is enabled, show bookmarks bar on NTP even if there aren't any bookmarks [Desktop] When setting is enabled, show bookmarks bar on NTP even if there aren't any bookmarks Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants