[Desktop] When setting is enabled, show bookmarks bar on NTP even if there aren't any bookmarks #10450
Labels
feature/bookmarks
growth/engagement
OS/Desktop
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/include
Milestone
Description
Follow up to #3568
In the issue above, we added informational/instructional text on the bookmarks bar to prompt users to import bookmarks. However, we don't show the bookmarks bar on NTP without any bookmarks (noted in #3568 (comment)).
Per discussion with @rebron since
Always show bookmarks on New Tab page
is the default setting, we should show this informational text on the bookmarks bar on the NTP.Steps to Reproduce
Show Bookmarks
is toggled off per default settings). This is fine.Actual result:
No bookmarks bar is displayed because there aren't any bookmarks
Expected result:
Bookmarks bar should be displayed with the instructional text from #3568
Reproduces how often:
easily
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc @rebron @simonhong
The text was updated successfully, but these errors were encountered: