Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Github Inline Tipping Broken #10434

Closed
corymcdonald opened this issue Jun 24, 2020 · 1 comment · Fixed by brave/brave-core#6789
Closed

[Desktop] Github Inline Tipping Broken #10434

corymcdonald opened this issue Jun 24, 2020 · 1 comment · Fixed by brave/brave-core#6789

Comments

@corymcdonald
Copy link

Description

Steps to Reproduce

  1. New Proxima-ui broke the github commits page for tipping. Other places as well

Actual result:

image

Reproduces how often:

Everytime

Brave version (brave://version info)

Brave | 1.12.25 Chromium: 83.0.4103.97 (Official Build) nightly (64-bit)

@LaurenWags
Copy link
Member

LaurenWags commented Nov 6, 2020

Verified passed with

Brave | 1.17.62 Chromium: 86.0.4240.185 (Official Build) dev (x86_64)
-- | --
Revision | 37e6f852ed18086458552039ad26421aa9fc7acc-refs/branch-heads/4240@{#1377}
OS | macOS Version 10.14.6 (Build 18G6032)

Verified in-line tip placement on the following pages:

Pull Request

PR description:
PR description

PR comment:
PR comment

Issue

Issue description:
Screen Shot 2020-11-06 at 8 50 58 AM

Issue comment:
Screen Shot 2020-11-06 at 8 51 56 AM

Commits Screen Shot 2020-11-06 at 8 52 46 AM
Starred Repos (must be logged in to GH) Screen Shot 2020-11-06 at 8 53 46 AM
Gist Screen Shot 2020-11-06 at 8 54 54 AM
People Page Screen Shot 2020-11-06 at 8 57 26 AM
Team Page (must be logged in to GH) Screen Shot 2020-11-06 at 8 56 48 AM

Additional testing was completed with #11463 (comment)


Verification passed on

Brave 1.17.68 Chromium: 87.0.4280.49 (Official Build) (64-bit)
Revision f77f85899646b42a1d3c8ff36794e00becab9171-refs/branch-heads/4280@{#1115}
OS Windows 7 Service Pack 1 (Build 7601.24544)
Pull Request

Confirmed in-line tip button displays on comment areas:

image
image
went thru as expected and were displayed on brave://rewards, brave://rewards-internals, and Monthly Summary.

Issue

Confirmed in-line tip button displays on comment areas:

image
image

Commits

Confirmed in-line tip button displays next to each commit:

image
image

Starred Repos (must be logged in to GH)

Confirmed in-line tip button displays next to each starred repo:

image
image

Team Members (need to be logged into GH)

Confirmed in-line tip button displays next to each user:

image

Gist

Confirmed in-line tip button displays in the page header:

image
image

Additional testing was completed with #11463 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants