[Desktop] [Mac OS] DCHECK and unexpected Tor window after restore

[iefremov]

STR:

1. MacOS, clean profile, launch the browser
2. Open TOR window
3. Focus the main window, close it
4. Close the TOR window, now the browser has no windows but still running
5. Cmd-N to open a new window. Now there are two windows - the normal one, and the TOR one with about:blank in the omnibox (screenshot)
6. Click into the TOR window omnibox, type any letter, press Enter - the browser hits DCHECK, if DCHECKs are disabled, the TOR window stays unusable

[10127:775:0618/193714.809841:FATAL:browser_finder.cc(228)] Check failed: web_contents. 
0   libbase.dylib                       0x000000011455de79 base::debug::CollectStackTrace(void**, unsigned long) + 9
1   libbase.dylib                       0x0000000114412343 base::debug::StackTrace::StackTrace() + 19
2   libbase.dylib                       0x0000000114436139 logging::LogMessage::~LogMessage() + 249
3   libchrome_dll.dylib                 0x000000010ed582f6 chrome::FindBrowserWithWebContents(content::WebContents const*) + 86
4   libchrome_dll.dylib                 0x000000010f1943a4 extensions::MaybeShowExtensionControlledSearchNotification(content::WebContents*, AutocompleteMatchType::Type) + 36
5   libchrome_dll.dylib                 0x000000010eb832bd OmniboxEditModel::OpenMatch(AutocompleteMatch, WindowOpenDisposition, GURL const&, std::__Cr::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__Cr::allocator<unsigned short> > const&, unsigned long, base::TimeTicks) + 2333
6   libchrome_dll.dylib                 0x000000010eb939d1 OmniboxView::OpenMatch(AutocompleteMatch const&, WindowOpenDisposition, GURL const&, std::__Cr::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__Cr::allocator<unsigned short> > const&, unsigned long, base::TimeTicks) + 97
7   libchrome_dll.dylib                 0x000000010eb82671 OmniboxEditModel::AcceptInput(WindowOpenDisposition, base::TimeTicks) + 1409
8   libchrome_dll.dylib                 0x000000010f06238a OmniboxViewViews::HandleKeyEvent(views::Textfield*, ui::KeyEvent const&) + 1610
9   libviews.dylib                      0x0000000121aabdd7 views::Textfield::OnKeyPressed(ui::KeyEvent const&) + 119
10  libviews.dylib                      0x0000000121af4653 non-virtual thunk to views::View::OnKeyEvent(ui::KeyEvent*) + 35
11  libevents.dylib                     0x000000011fcb7e98 ui::EventDispatcher::ProcessEvent(ui::EventTarget*, ui::Event*) + 280
12  libevents.dylib                     0x000000011fcb7c7a ui::EventDispatcherDelegate::DispatchEventToTarget(ui::EventTarget*, ui::Event*) + 90
13  libevents.dylib                     0x000000011fcb7bb9 ui::EventDispatcherDelegate::DispatchEvent(ui::EventTarget*, ui::Event*) + 137
14  libevents.dylib                     0x000000011fcba1de ui::EventProcessor::OnEventFromSource(ui::Event*) + 606
15  libevents.dylib                     0x000000011fcbb3d7 ui::EventSource::DeliverEventToSink(ui::Event*) + 87
16  libevents.dylib                     0x000000011fcbb2e2 ui::EventSource::SendEventToSinkFromRewriter(ui::Event const*, ui::EventRewriter const*) + 434
17  libviews.dylib                      0x0000000121b0d196 views::Widget::OnKeyEvent(ui::KeyEvent*) + 22
18  libviews.dylib                      0x0000000121b36d56 views::NativeWidgetMac::DispatchKeyEventPostIME(ui::KeyEvent*) + 134
19  libui_base_ime.dylib                0x0000000121e39163 ui::InputMethodBase::DispatchKeyEventPostIME(ui::KeyEvent*) const + 19
20  libapp_shim.dylib                   0x0000000122aee094 -[BridgedContentView handleKeyEvent:] + 132
21  libapp_shim.dylib                   0x0000000122aee121 -[BridgedContentView handleUnhandledKeyDownAsKeyEvent] + 97
22  libapp_shim.dylib                   0x0000000122aeef0f -[BridgedContentView keyDown:] + 207
23  AppKit                              0x00007fff35b3154d -[NSWindow(NSEventRouting) _reallySendEvent:isDelayedEvent:] + 6512
24  AppKit                              0x00007fff35b2f9b9 -[NSWindow(NSEventRouting) sendEvent:] + 349
25  libapp_shim.dylib                   0x0000000122af430c -[NativeWidgetMacNSWindow sendEvent:] + 348
26  AppKit                              0x00007fff35b2e6ee -[NSApplication(NSEvent) sendEvent:] + 2826
27  libchrome_dll.dylib                 0x000000010d3b851a __34-[BrowserCrApplication sendEvent:]_block_invoke + 218
28  libbase.dylib                       0x0000000114577aaa base::mac::CallWithEHFrame(void () block_pointer) + 10
29  libchrome_dll.dylib                 0x000000010d3b82a2 -[BrowserCrApplication sendEvent:] + 962
30  AppKit                              0x00007fff3597adaf -[NSApplication run] + 707
31  libbase.dylib                       0x000000011458522c base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 348
32  libbase.dylib                       0x00000001145832b2 base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 130
33  libbase.dylib                       0x00000001144db542 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta) + 242
34  libbase.dylib                       0x000000011448a485 base::RunLoop::Run() + 821
35  libchrome_dll.dylib                 0x000000010d3c9507 ChromeBrowserMainParts::MainMessageLoopRun(int*) + 199
36  libcontent.dylib                    0x0000000118749d7c content::BrowserMainLoop::RunMainMessageLoopParts() + 76
37  libcontent.dylib                    0x000000011874c496 content::BrowserMainRunnerImpl::Run() + 102
38  libcontent.dylib                    0x0000000118746c5b content::BrowserMain(content::MainFunctionParams const&) + 267
39  libcontent.dylib                    0x0000000119449138 content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) + 1080
40  libcontent.dylib                    0x0000000119448cd3 content::ContentMainRunnerImpl::Run(bool) + 531
41  libembedder.dylib                   0x00000001143b283c service_manager::Main(service_manager::MainParams const&) + 3180
42  libcontent.dylib                    0x0000000119447f78 content::ContentMain(content::ContentMainParams const&) + 120
43  libchrome_dll.dylib                 0x000000010c18fb35 ChromeMain + 277
44  Brave Browser Development           0x000000010bfdb69f main + 287
45  libdyld.dylib                       0x00007fff72710cc9 start + 1

[0618/193715.077977:WARNING:system_snapshot_mac.cc(42)] sysctlbyname kern.nx: No such file or directory (2)
[0618/193715.091864:WARNING:crash_report_exception_handler.cc(239)] UniversalExceptionRaise: (os/kern) failure (5)

Brave	1.12.14 Chromium: 83.0.4103.97 (Developer Build) (64-bit)
Revision	326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS	macOS Version 10.15.5 (Build 19F101)

[iefremov]

cc @yrliou @darkdh
cc @bsclifton @rebron @kjozwiak to prioritize

[rebron]

cc: @darkdh Your fix to lazyload Tor, does it fix this crash?

[darkdh]

no, it is completely irrelevant