Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Brave shows 'Show Frame-Sourcecode' in contextmenu every time #10346

Closed
BerkeAras opened this issue Jun 17, 2020 · 6 comments
Closed
Labels
Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix closed/works-for-me feature/context-menu OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. repros-on-chrome

Comments

@BerkeAras
Copy link

Description

Brave Browser thinks the website contains an iframe and shows 'Show Frame-Sourcecode' in the context menu every time.

Steps to Reproduce

  1. Open a basic website
  2. Just rightclick anywhere
  3. See bug

Actual result:

(German)
image

Expected result:

It should not show the Frame options when there is no frame.

Brave version (brave://version info)

Brave: 1.10.90 Chromium: 83.0.4103.97 (Official Build) (64-bit)
Revision: 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS: Windows 10 OS Version 1909 (Build 18363.836)

Version/Channel Information:

It happens in the latest release.

@ko2in
Copy link

ko2in commented Jun 22, 2020

Yes. I've the same issue. I see 'View frame source' and 'Reload frame' in every web pages.

Version:

Brave: Version 1.10.93 Chromium: 83.0.4103.106 (Official Build) (64-bit)
OS: Ubuntu 18.04.4 LTS (64bit)

@SoftCreatR
Copy link

SoftCreatR commented Jun 23, 2020

Same here and it's somewhat annoying.

Brave version (brave://version info)

Brave: 1.10.95 Chromium: 83.0.4103.106 (Official Build) (64-bit)
Revision: 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS: Windows 10 OS Version 2004 (Build 19041.329)

@bsclifton
Copy link
Member

This is interesting; it seems to be present in Google Chrome too-
image

I'm not sure why it would show both?

@bsclifton bsclifton added Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix repros-on-chrome labels Jun 23, 2020
@SoftCreatR
Copy link

@bsclifton
Copy link
Member

@SoftCreatR nice! Thanks for finding / sharing the upstream bug 😄

@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Aug 7, 2020
@bsclifton
Copy link
Member

Closing as this was fixed with Chromium 84 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix closed/works-for-me feature/context-menu OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. repros-on-chrome
Projects
None yet
Development

No branches or pull requests

5 participants