Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] #extensions-toolbar-menu no longer works when enabled after update to v1.10.90 #10317

Open
Brave-Matt opened this issue Jun 16, 2020 · 1 comment
Labels
feature/extensions feature/settings needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop

Comments

@Brave-Matt
Copy link

Description

Brave update to v1.10.90 breaks the #extensions-toolbar-menu flag. When the flag is enabled, the Extension toolbar menu shows, but all the extensions still appear on the toolbar:
image

Steps to Reproduce

  1. Launch Brave and visit brave://flags
  2. Search for and enable the #extensions-toolbar-menu flag.
  3. Relaunch the browser and note that extensions still appear on the toolbar

Actual result:

[See image above] Extensions continue to appear on toolbar (and in extension menu)

Expected result:

Extensions should appear only in the menu while the flag is enabled.

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.10.90 Chromium: 83.0.4103.97 (Official Build) (64-bit)
Revision 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS macOS Version 10.15.5 (Build 19F101)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? No.

Miscellaneous Information:

I was able to reproduce this on Linux, Windows and macOS.
Original user report: https://community.brave.com/t/todays-brave-update-extensions-toolbar-menu-not-working/135501

@Brave-Matt Brave-Matt changed the title [Desktop] [Desktop] #extensions-toolbar-menu no longer works when enabled after update to v1.10.90 Jun 16, 2020
@rebron
Copy link
Collaborator

rebron commented Aug 7, 2020

Considering to wontfix this as this is a chrome flag and not a supported feature.

@rebron rebron added the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label Aug 7, 2020
@rebron rebron added this to General May 28, 2024
@rebron rebron moved this to Needs Info in General May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/extensions feature/settings needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop
Projects
Status: Needs Info
Development

No branches or pull requests

2 participants