Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Replace graphics on Make a call popup #10308

Closed
srirambv opened this issue Jun 16, 2020 · 7 comments
Closed

[Desktop] Replace graphics on Make a call popup #10308

srirambv opened this issue Jun 16, 2020 · 7 comments
Labels
branding closed/by-author design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. design A design change, especially one which needs input from the design team needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

Replace graphics on Make a call popup

Steps to Reproduce

  1. Visit any page with a tel:xxxxxx link
  2. Click on the call button
  3. See Chromium card with graphics

Actual result:

image

Expected result:

Should use custom graphics or no graphics

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.12.25 Chromium: 83.0.4103.97 (Official Build) nightly (64-bit)
Revision 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the dev channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

@srirambv srirambv added design A design change, especially one which needs input from the design team design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. QA/Yes release-notes/exclude branding OS/Desktop labels Jun 16, 2020
@rebron
Copy link
Collaborator

rebron commented Jun 23, 2020

@karenkliu We could probably just remove this image altogether.

@rebron rebron added the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label Jun 23, 2020
@karenkliu
Copy link

@rebron Not sure if we want to remove graphics on all the popups - I think they're helpful on some to distinguish visually its purpose. If we removed the graphics from all the popups it would be hard to tell them apart.

@codybanxs created this graphic for us - think it'll work?

image

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Aug 7, 2020
@rebron
Copy link
Collaborator

rebron commented Aug 7, 2020

@karenkliu @codybanxs Fine to replace and that graphic looks good although I think we need it to fit dimensions that will work for here -> https://user-images.githubusercontent.com/17010094/84795440-1e74e300-b015-11ea-903e-36942b7fe351.png

@karenkliu
Copy link

@codybanxs can you come up with something that is a bit more horizontal?

@rebron rebron assigned ghost and unassigned rebron Oct 26, 2020
@ghost
Copy link

ghost commented Oct 26, 2020

@karenkliu @rebron I will work on a horizontal style graphic for this.

@rebron
Copy link
Collaborator

rebron commented Apr 13, 2021

@srirambv Can you recheck? I think this is no longer valid now due to #14601

@srirambv
Copy link
Contributor Author

Yup this seems to be no longer valid. Closing the issue
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branding closed/by-author design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. design A design change, especially one which needs input from the design team needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude
Projects
None yet
Development

No branches or pull requests

3 participants