Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Set the updater endpoint at build time #10279

Closed
jumde opened this issue Jun 15, 2020 · 3 comments · Fixed by #10281 or brave/brave-core#5854
Closed

[Desktop] Set the updater endpoint at build time #10279

jumde opened this issue Jun 15, 2020 · 3 comments · Fixed by #10281 or brave/brave-core#5854

Comments

@jumde
Copy link
Contributor

jumde commented Jun 15, 2020

Description

Use npm config to set the updater config at build time.

Test Plan

Specified here: #10281

@LaurenWags
Copy link
Member

Labeling as QA/Blocked as I've requested test plan clarification from @jumde

@LaurenWags
Copy link
Member

LaurenWags commented Jul 29, 2020

Verified passed with

Brave | 1.12.104 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | macOS Version 10.14.6 (Build 18G3020)

Screen Shot 2020-07-29 at 3 34 29 PM

  • Using dev go-updater:

Screen Shot 2020-07-29 at 3 42 01 PM


Verification passed on

Brave 1.12.104 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS Ubuntu 18.04 LTS
  • Production
    image

  • Using dev go-updater:
    image

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 30, 2020

Verification passed on

Brave | 1.12.104 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | Windows 10 OS Version 1903 (Build 18362.959)

Using production go-updater

  • Ensured that the following components download successfully in brave://components
    • Brave Local Data Update
    • Brave Ad Block Updater
    • Brave Tor Client Updater
    • NTP Sponsored Images (US)
    • Brave SpeedReader Updater
    • Brave HTTPS Everywhere Updater
    • CRLSets

image

with --use-dev-goupdater-url

  • Ensured that the above components download successfully in brave://components
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment