Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fingerprinting protection mode unintentionally breaks several popular sites #1025

Closed
bsclifton opened this issue Sep 7, 2018 · 14 comments
Closed
Labels
closed/duplicate Issue has already been reported feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields needs-investigation A bug not 100% confirmed/fixed priority/P4 Planned work. We expect to get to it "soon". webcompat/shields Shields is breaking a website.

Comments

@bsclifton
Copy link
Member

Carried over from brave/browser-laptop#2965

Several popular sites are broken (or were broken with browser-laptop) if you enable fingerprinting:

  • Google Hangouts
  • icloud.com
  • dropbox PDF documents
  • Google sheets
  • messenger.com
  • maps.google.com
  • fonts.google.com
  • photos.google.com
  • sketchfab.com
@bsclifton bsclifton added feature/global-settings Settings at browser level independent of shields settings feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields labels Sep 7, 2018
@bsclifton bsclifton added this to the Triage Backlog milestone Sep 7, 2018
@bsclifton bsclifton added the webcompat/not-shields-related Sites are breaking because of something other than Shields. label Sep 7, 2018
@bbondy bbondy modified the milestones: 2.x Backlog, 1.x Backlog Sep 30, 2018
@pes10k
Copy link
Contributor

pes10k commented Oct 1, 2018

I'm not able to re-create on on some of these. Specifically, the following work with default config:

@tildelowengrimm tildelowengrimm added webcompat/shields Shields is breaking a website. needs-investigation A bug not 100% confirmed/fixed and removed webcompat/not-shields-related Sites are breaking because of something other than Shields. feature/global-settings Settings at browser level independent of shields settings labels Nov 5, 2018
@tildelowengrimm tildelowengrimm added the priority/P4 Planned work. We expect to get to it "soon". label Nov 7, 2018
@tildelowengrimm
Copy link
Contributor

@bsclifton Could you give more detailed repro steps?

@ericdstoltz
Copy link

I'm running into this problem with google maps. It seems to effect smooth zoom functionality. With fingerprinting block turned off the maps zoom smoothly similar to chrome and safari. With it turned on the zoom function is impacted so that it is almost unusable.

@bsclifton
Copy link
Member Author

@tomlowenthal the original issue has reports which include steps

@anto-christo
Copy link

I am not sure whether this is related to this issue but I just ran into this.

fonts.google.com

With Shield disabled:

disabled

With Shield enabled:

enabled

As you can see, the example fonts are not being rendered with shield up.

@srirambv
Copy link
Contributor

@anto-christo You have Device recognition blocked so any kind of fingerprinting will not work. May be the site requires you to allow fingerprinting to show the fonts correctly. Try setting it to 3rd party device recognition blocked and see if it works.

@anto-christo
Copy link

@srirambv , setting it to 3rd party device recognition blocked did work. As you pointed out, the site needs fingerprinting. Maybe to display fonts in regional languages. Thanks for pointing it out !!

@tildelowengrimm
Copy link
Contributor

tildelowengrimm commented Dec 14, 2018

Looks like it's essentially working as intended on Google Fonts.

@bsclifton
Copy link
Member Author

+1 from #5073

There is a possibility we could have a more obvious UX to let people know device recognition was blocked and may be affecting their experience

@Yuki2718
Copy link

Is this only for popular sites? Fingerprinting protection breaks games on kizi.com such as https://kizi.com/games/down-the-mountain.

kizi

@pes10k
Copy link
Contributor

pes10k commented Apr 28, 2020

@Yuki2718 we're in the process of moving to a new system of protecting against fingerprinting that should address the vast majority of these cases #8787.

This is under implementation right now. The immediate fix is to disable fingerprinting attempts on sites like this that you trust. But the linked to meta-issue will be the "real" fix, that should be released before too long

@Yuki2718
Copy link

@pes10k Okay, the coming change looks promising. How about creating a centralized issue tracker which gathers all the problem arising from fingerprinting protection so that any issue can be reported there and you can address each issues in an optimal way (per-site configuration for problematic sites)?

@pes10k
Copy link
Contributor

pes10k commented Apr 30, 2020

Currently we try to use GH labels for that, instead of needing to continually update issue text. So, i think opening new issues (feel free to CC me and @ryanbr ) would be ideal, and we can label them accordingly.

It would also be fine to report those issues as comments on #8787

Thanks!

@pes10k
Copy link
Contributor

pes10k commented Sep 1, 2020

I'm going to close this since its not actionable in its current form , and we're using #8787 going forward to track webcompat issues. Thanks everyone!

@pes10k pes10k closed this as completed Sep 1, 2020
@pes10k pes10k added the closed/duplicate Issue has already been reported label Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields needs-investigation A bug not 100% confirmed/fixed priority/P4 Planned work. We expect to get to it "soon". webcompat/shields Shields is breaking a website.
Projects
None yet
Development

No branches or pull requests

9 participants