Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the query string filter to a proper list #10188

Open
fmarier opened this issue Jun 9, 2020 · 6 comments
Open

Move the query string filter to a proper list #10188

fmarier opened this issue Jun 9, 2020 · 6 comments
Assignees
Labels
priority/P4 Planned work. We expect to get to it "soon". privacy/query-filter privacy

Comments

@fmarier
Copy link
Member

fmarier commented Jun 9, 2020

The following query parameters will require extra functionality in the query string filter:

We should design a list format that will support all of these use cases.

In addition, instead of being hard-coded in code, the list should ideally be shipped via the component updater and be hosted in a public repo for others to contribute to.

@fmarier fmarier added privacy privacy/query-filter priority/P3 The next thing for us to work on. It'll ride the trains. labels Jun 9, 2020
@fmarier
Copy link
Member Author

fmarier commented Jun 15, 2020

#8975 doesn't require a list format change and is therefore not blocked on the current issue.

Since #9018 is the only tracking parameter that requires a list format change, let's wait until we have a few more examples before we migrate to a more flexible system.

@fmarier fmarier added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jun 15, 2020
@Th3l5D
Copy link

Th3l5D commented Sep 26, 2020

Hello @fmarier

Is there any news for this feature?
I would like to know if there is any plan to integrate this kind of feature globally, in order to have something like https://gitlab.com/KevinRoebert/ClearUrls/ which have a nice query filter ( https://gitlab.com/KevinRoebert/ClearUrls/blob/master/data/data.min.json )

@fmarier
Copy link
Member Author

fmarier commented Sep 28, 2020

@Th3l5D Thanks for the link. It is one of the extensions I looked at while putting together our own list.

The goal of our feature is to block cross-site tracking (see https://github.com/brave/brave-browser/wiki/Query-String-Filter) and so our list format wouldn't have to be as comprehensive what ClearUrls has, which aims at cleaning URLs of all unnecessary bits.

Work is progressing on our filter. It's alreay in release, we've recently added new trackers, and have identified a few more that need to be looked at or blocked.

@fmarier
Copy link
Member Author

fmarier commented Jul 13, 2021

Unassigning since we're not actively working on this at the moment.

@antonok-edm
Copy link
Collaborator

Note that $removeparam support is coming in brave/brave-core#15943

@fmarier
Copy link
Member Author

fmarier commented Oct 15, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/P4 Planned work. We expect to get to it "soon". privacy/query-filter privacy
Projects
None yet
Development

No branches or pull requests

5 participants