-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the query string filter to a proper list #10188
Comments
Hello @fmarier Is there any news for this feature? |
@Th3l5D Thanks for the link. It is one of the extensions I looked at while putting together our own list. The goal of our feature is to block cross-site tracking (see https://github.com/brave/brave-browser/wiki/Query-String-Filter) and so our list format wouldn't have to be as comprehensive what ClearUrls has, which aims at cleaning URLs of all unnecessary bits. Work is progressing on our filter. It's alreay in release, we've recently added new trackers, and have identified a few more that need to be looked at or blocked. |
Unassigning since we're not actively working on this at the moment. |
Note that |
@ShivanKaul and I were just discussing this. As a first step, I suggested using the same list format as https://github.com/brave/adblock-lists/blob/master/brave-lists/clean-urls.json which would allow us to move these two hard-coded lists to a new https://github.com/brave/adblock-lists/blob/master/brave-lists/query-filter.json list:
and we can leave the smallest block hard-coded for now since it's only three entries: https://github.com/brave/brave-core/blob/cdfe99bd6b9d7c8f6b7eb0b05b3db795ec7e4ca2/components/query_filter/utils.cc#L125-L132 |
The following query parameters will require extra functionality in the query string filter:
We should design a list format that will support all of these use cases.
In addition, instead of being hard-coded in code, the list should ideally be shipped via the component updater and be hosted in a public repo for others to contribute to.
The text was updated successfully, but these errors were encountered: