Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable RTCInsertable streams via origin policy #10060

Closed
jumde opened this issue Jun 2, 2020 · 1 comment · Fixed by brave/brave-core#5706
Closed

Enable RTCInsertable streams via origin policy #10060

jumde opened this issue Jun 2, 2020 · 1 comment · Fixed by brave/brave-core#5706
Labels
OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.12.x - Release #1

Comments

@jumde
Copy link
Contributor

jumde commented Jun 2, 2020 •
edited
Loading

Description

together.brave.com will use E2E encryption. To enable this we need to enable RTCInsertable streams using origin trials.

Test Plan

Specified here: brave/brave-core#5706
@jumde jumde mentioned this issue Jun 2, 2020
Merged
32 tasks
@jumde jumde added this to the 1.12.x - Nightly milestone Jun 5, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Jul 17, 2020 •
edited by btlechowski
Loading

Verified passed with

Brave | 1.12.92 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | macOS Version 10.14.6 (Build 18G3020)

1 11 97

  • Confirmed insertable streams are supported with 1.12.92:

1 12 92

  • Confirmed Crypto key input box is disabled:

Screen Shot 2020-07-17 at 11 57 54 AM

  • Note, second site from test plan shows insertable streams as not supported, discussed with @jumde and confirmed this is expected based on configuration.

Verification passed on


Brave | 1.12.101 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | Windows 10 OS Version 1903 (Build 18362.959)

  • Confirmed insertable streams are not supported with 1.11.101:
    image

  • Confirmed insertable streams are supported with 1.12.101:
    image

  • Confirmed Crypto key input box is disabled:
    image

Verification passed on

Brave 1.12.102 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS Ubuntu 18.04 LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.12.x - Release #1
Development

Successfully merging a pull request may close this issue.

Fix 10060: Add a new public key for origin trials brave/brave-core
4 participants
@jumde @LaurenWags @btlechowski @GeetaSarvadnya