Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Remove Rewards Debug settings on x86 #10011

Closed
LaurenWags opened this issue May 29, 2020 · 1 comment · Fixed by brave/brave-core#5700
Closed

[Android] Remove Rewards Debug settings on x86 #10011

LaurenWags opened this issue May 29, 2020 · 1 comment · Fixed by brave/brave-core#5700
Assignees
Labels
feature/rewards OS/Android Fixes related to Android browser functionality QA Pass - Android x86 QA/Yes release-notes/include x86 Android x86 related issues

Comments

@LaurenWags
Copy link
Member

LaurenWags commented May 29, 2020

Description

x86 devices do not have Rewards so they do not need the Rewards Debug section in Developer options.

Rewards options are not needed in QA Preferences section either, but this is probably of less importance.

Related to #9766

Steps to reproduce

  1. Using x86 device go to Developer options --> See Rewards Debug section

Actual result

Rewards Debug section

Expected result

No rewards settings for x86 devices

Issue reproduces how often

easily

Issue happens on

  • Current Play Store version?
  • Beta build? yes

Device details

  • Install type (ARM, x86): x86
  • Device (Phone, Tablet, Phablet): all
  • Android version: all

Brave version

1.9.77

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

cc @srirambv @anthonypkeane @SergeyZhukovsky @samartnik

@LaurenWags
Copy link
Member Author

Verification passed on Asus Zenfone (x86) with Android 6.0 running 1.11.98 using BraveModernx86.apk

  • Verified STR from description
    Android-10011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards OS/Android Fixes related to Android browser functionality QA Pass - Android x86 QA/Yes release-notes/include x86 Android x86 related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants