Skip to content

Commit

Permalink
Merge pull request #755 from brave/single-process
Browse files Browse the repository at this point in the history
Add ability to start single process and add ability to start unofficial Release builds on macOS
  • Loading branch information
bbondy committed Aug 15, 2018
2 parents 08a9a13 + 41b1338 commit 3924de4
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lib/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ Config.prototype.update = function (options) {
this.officialBuild = this.buildConfig === 'Release'
}

if (this.debugBuild) {
if (!this.officialBuild) {
this.channel = 'development'
} else if (options.channel !== 'release') {
// In chromium src, empty string represents stable channel.
Expand Down
3 changes: 3 additions & 0 deletions lib/start.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ const start = (buildConfig = config.defaultBuildConfig, options) => {
// This only has meaning with MacOS and official build.
braveArgs.push('--disable-brave-update')
}
if (options.single_process) {
braveArgs.push('--single-process')
}

let cmdOptions = {
stdio: 'inherit',
Expand Down
2 changes: 2 additions & 0 deletions scripts/commands.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ program
.option('--disable_pdfjs_extension', 'disable loading the PDFJS extension')
.option('--enable_brave_update', 'enable brave update')
.option('--channel <target_chanel>', 'target channel to start', /^(beta|dev|nightly|release)$/i, 'release')
.option('--official_build <official_build>', 'force official build settings')
.option('--single_process', 'use a single process')
.arguments('[build_config]')
.action(start)

Expand Down

0 comments on commit 3924de4

Please sign in to comment.