Skip to content
This repository has been archived by the owner on Apr 25, 2024. It is now read-only.

Revert "Fix mpris slot name" #22

Closed
wants to merge 1 commit into from

Conversation

jayschwa
Copy link

@jayschwa jayschwa commented Mar 2, 2023

Reverts #19

MPRIS slot name should now use the default of "brave" now that brave/brave-core#17440 has been merged.

@jayschwa jayschwa requested a review from a team as a code owner March 2, 2023 18:07
@mihaiplesa mihaiplesa requested a review from fmarier March 2, 2023 18:42
Copy link
Member

@fmarier fmarier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. However it hasn't made it to release yet (it's just in Nightly so far), and so let's hold merging the PR until it's in release.

@wknapik
Copy link

wknapik commented May 3, 2023

Merged #21, this won't be needed

@wknapik wknapik closed this May 3, 2023
@jayschwa jayschwa deleted the revert-19-fix-mpris branch May 3, 2023 20:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants