Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor / rebuild sharing #81

Open
14 tasks
brantje opened this issue Apr 10, 2018 · 0 comments
Open
14 tasks

Refactor / rebuild sharing #81

brantje opened this issue Apr 10, 2018 · 0 comments
Milestone
Release

Comments

@brantje
Copy link
Owner

brantje commented Apr 10, 2018 •
edited
Loading

Due an unannounced API change in the Nextcloud core, i was forced to quickly copying their old code.
This resulted in a big, ugly file

This issue is about refactoring the sharing part in the app.
It will fix a lot of current sharing issues and add some new features.

  • Switch to GUIDs in routes
  • Update API docs to use GUID's
  • Make a table that holds the shares
  • Use binary operators for permissions
  • Implement user to user sharing
    • Re-share permission
    • Edit permission
    • Delete permission
  • Implement notebook sharing
    • Re-share permission
    • Edit permission
    • Delete permission
  • Implement link sharing
    • Edit permission (include a warning that everyone with the link can edit)
@brantje brantje added this to the Release milestone Apr 10, 2018
This was referenced Apr 13, 2018
Closed
Merged
@brantje brantje changed the title Refactor sharing Refactor / rebuild sharing Apr 14, 2018
@brantje brantje mentioned this issue Apr 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release
Development

No branches or pull requests
1 participant
@brantje