add import loader (since webpack v2.1.0-beta.28) #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brandonroberts Please help to review this PR since webpack 3 has removed |
brandonroberts
requested changes
Nov 14, 2017
docs/options.md
Outdated
|
|
||
| If you prefer to use `dynamic import`, set the `loader` to `import` | ||
|
|
||
| **NOTE:** Using `import` only works with Webpack >= 2.1.0-beta.28. |
There was a problem hiding this comment.
Change to Webpack => 2.1.0 since its already been officially released
docs/options.md
Outdated
| } | ||
| ``` | ||
|
|
||
| If you prefer to use `dynamic import`, set the `loader` to `import` |
There was a problem hiding this comment.
@brandonroberts I add If you prefer here because it is also mentioned in If you prefer to use System.import, set the loader to system, so should I remove that also?
|
@JounQin will you add a test to verify the |
brandonroberts
approved these changes
Nov 14, 2017
|
Thanks! |
|
Published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/webpack/webpack/releases/tag/v2.1.0-beta.28