feat(loader): Update regex to be able to use double-quotes and single…

…-quotes (#80)
brandonroberts · Nov 14, 2017 · 0444b6e · 0444b6e
1 parent 7d1f7f3
commit 0444b6e
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/spec/index.spec.js b/spec/index.spec.js
@@ -24,7 +24,21 @@ describe('Loader', function() {
       `loadChildren: "${modulePath}"`,
       `loadChildren:"${modulePath}"`,
       `loadChildren :"${modulePath}"`,
-      `loadChildren : "${modulePath}"`
+      `loadChildren : "${modulePath}"`,
+
+      `"loadChildren":"${modulePath}"`,
+      `"loadChildren": "${modulePath}"`,
+      `"loadChildren" : "${modulePath}"`,
+      `"loadChildren" :  "${modulePath}"`,
+      `"loadChildren"  :"${modulePath}"`,
+      `"loadChildren"  : "${modulePath}"`,
+
+      `'loadChildren':"${modulePath}"`,
+      `'loadChildren': "${modulePath}"`,
+      `'loadChildren' : "${modulePath}"`,
+      `'loadChildren' :  "${modulePath}"`,
+      `'loadChildren'  :"${modulePath}"`,
+      `'loadChildren'  : "${modulePath}"`
     ];
 
     loadStrings.forEach(function(loadString) {

diff --git a/src/index.js b/src/index.js
@@ -6,7 +6,7 @@ module.exports = function(source, sourcemap) {
   this.cacheable && this.cacheable();
 
   // regex for loadChildren string
-  var loadChildrenRegex = /loadChildren[\s]*:[\s]*['|"](.*?)['|"]/gm;
+  var loadChildrenRegex = /["']?loadChildren["']?[\s]*:[\s]*['|"](.*?)['|"]/gm;
 
   // parse query params
   var query = loaderUtils.getOptions(this) || {};