Fixing new line issue #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the contribution and your bug report :) The root cause of this is the Could you make that change? I do not think we need to rely on trimming after this fix. |
koopa1338
force-pushed
the
fix/rustfmt-stdin-newline
branch
from
388b3e7 to
b4b459d
Compare
|
You were right, edited my pr and tested this also with multiple calls to the formatter. |
bram209
approved these changes
Dec 21, 2023
|
Looking good, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading from stdin and stdout is, including newlines, for the formatted output of letposfmt as well as rustfmt. Rustfmt should already trim any empty lines at the end of a file, so this should be safe to do when reading the output and trim the ending new line.
This fixes #92 and #94 as well