Correctly format files with dos line endings #81

nikhilraojl · 2023-09-20T13:52:54Z

Closes #80

I did this the simplest way, but it may not be the right way. Please suggest if something can be improved or changed

printer/src/algorithm.rs

bram209 · 2023-09-20T14:45:47Z

printer/src/algorithm.rs

        }
    }

+    pub fn set_dos(&mut self, value: bool) {


we could pass this to the constructor of Printer instead, no need for a setter in that case.
(I don't think you would ever switch to a different line ending style halfway formatting, so it does not have to be mutable)

formatter/src/formatter/mac.rs

bram209 · 2023-09-20T14:52:01Z

hey, thanks for your contribution!

I am not really a fan of platform specific line endings. Files are transferred from one platform to the other, etc. And I believe on the reading side every editor would be able to read LF line endings? I haven't use windows in ages, but I think you could configure git to automatically convert line endings to LF.

Anyhow, it is still nice to support this. Code looks good to me, only have some very minor suggestions (mostly naming), well done 👍

bram209 · 2023-09-20T15:01:00Z

I think most people will be fine with having the formatter automatically detect line endings, but if you feel like it, you could also add a configuration option newline_style to FormatterSettings like so:

https://github.com/bram209/leptosfmt/blob/main/formatter/src/formatter/mod.rs#L38

This could have the following variants: Auto, Native, Windows, Unix.

Where Native you could use conditional compilation, like so:

val crlf_line_endings =  cfg!(windows)

But if you want to leave it at what you currently have, that is perfectly fine as well : )

nikhilraojl · 2023-09-21T05:52:12Z

I haven't use windows in ages, but I think you could configure git to automatically convert line endings to LF.

CRLF is default on windows. But git will replace CRLF as LF when a commit is done, but files will stay as CRLF for editing locally. I understand this is not good but that's windows 🤷 . I will try to move away from CRLF

I think most people will be fine with having the formatter automatically detect line endings, but if you feel like it, you could also add a configuration option newline_style to FormatterSettings like so:

I would like to do this later as I don't conditional compilation stuff yet. Will definitely give it a go later

formatter/src/formatter/mac.rs

* Correctly format files with dos line endings * Refactor and naming improvements * Avoid panic on empty file [skip ci] Update CHANGELOG.md [skip ci] Update CHANGELOG.md

Correctly format files with dos line endings

f077b3c