Form actions patch #286
Merged
Form actions patch #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think its better to use underscores for clarity, Besides the comment, +1 from me. |
|
I agree with @sstok |
|
Yes, your both absolutely right |
* fixes double 'type' in markup bug * allows usage of BS-Button styled <a>-Tag * (+1 squashed commits) Squashed commits: [6f1d0e4] renaming button extensions new options for better clarity
florianeckerstorfer
pushed a commit
that referenced
this pull request
Aug 21, 2014
Form actions patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently to get different coloured buttons you had to have a something like
"type" => "danger"in theattrarray. Since all entries in attr are rendered into markup inbutton_attributesblock, you end up with twotypeattributes in your markup.This ButtonExtension introduces a new option
buttonclassfor that purpose.In addition it also provides the possibility to render an
<a>-tag as BS-styled button using the option"asatag" => trueand having thehrefin theattrarray.