Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing placeholder application in inline forms #252

Merged
merged 1 commit into from
Jun 15, 2014

Conversation

rdohms
Copy link
Contributor

@rdohms rdohms commented Jun 13, 2014

The current code triggers label => false in inline forms to use name|humanize as the placeholder.
This is wrong and if label is set explicitly to false it should trigger no placeholder.

This fix adds the extra check to avoid this behavior.

Should this be applied to any other branches?

The current code triggers `label => false` in `inline` forms to use `name|humanize` as the placeholder.
This is wrong and if label is set explicitly to `false` it should trigger no placeholder.

This fix adds the extra check to avoid this behavior.
florianeckerstorfer pushed a commit that referenced this pull request Jun 15, 2014
Fixing placeholder application in inline forms
@florianeckerstorfer florianeckerstorfer merged commit 1db8af4 into braincrafted:develop Jun 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants