From 8489d8f6b8df201a6a9f678045c02476a37d7033 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20P=C3=BCschel?= <pue@der-pue.de>
Date: Thu, 14 Aug 2014 11:50:43 +0200
Subject: [PATCH 1/2] removing additional whitespaces in <button> markup

---
 Resources/views/Form/bootstrap.html.twig | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/Resources/views/Form/bootstrap.html.twig b/Resources/views/Form/bootstrap.html.twig
index 8c73c1f..2e58d77 100644
--- a/Resources/views/Form/bootstrap.html.twig
+++ b/Resources/views/Form/bootstrap.html.twig
@@ -894,9 +894,7 @@
     {% endspaceless %}
 {% endblock widget_container_attributes %}
 
-{% block button_attributes %}
-    {% spaceless %}
+{% block button_attributes -%}
         id="{{ id }}" name="{{ full_name }}"{% if disabled %} disabled="disabled"{% endif %}
-        {% for attrname, attrvalue in attr %}{{ attrname }}="{{ attrvalue }}" {% endfor %}
-    {% endspaceless %}
+        {%- for attrname, attrvalue in attr %} {{ attrname }}="{{ attrvalue }}"{% endfor %}
 {% endblock button_attributes %}

From 679c67ed102d4f6cf6007914cc1eea2f18df2d35 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20P=C3=BCschel?= <pue@der-pue.de>
Date: Thu, 14 Aug 2014 11:29:33 +0200
Subject: [PATCH 2/2] Adding ButtonTypeExtension which: * fixes double 'type'
 in markup bug * allows usage of BS-Button styled <a>-Tag * (+1 squashed
 commits)

Squashed commits:

[6f1d0e4] renaming button extensions new options for better clarity
---
 Form/Extension/ButtonTypeExtension.php   | 46 ++++++++++++++++++++++++
 Resources/config/services/form.xml       |  5 +++
 Resources/views/Form/bootstrap.html.twig | 10 ++++--
 3 files changed, 58 insertions(+), 3 deletions(-)
 create mode 100644 Form/Extension/ButtonTypeExtension.php

diff --git a/Form/Extension/ButtonTypeExtension.php b/Form/Extension/ButtonTypeExtension.php
new file mode 100644
index 0000000..ea56b76
--- /dev/null
+++ b/Form/Extension/ButtonTypeExtension.php
@@ -0,0 +1,46 @@
+<?php
+
+namespace Braincrafted\Bundle\BootstrapBundle\Form\Extension;
+
+use Symfony\Component\Form\AbstractTypeExtension;
+use Symfony\Component\OptionsResolver\OptionsResolverInterface;
+use Symfony\Component\Form\FormView;
+use Symfony\Component\Form\FormInterface;
+
+/**
+ * FormControlStaticType
+ *
+ * @package    BraincraftedBootstrapBundle
+ * @subpackage Form
+ * @author     André Püschel <pue@der-pue.de>
+ * @copyright  2014 André Püschel
+ * @license    http://opensource.org/licenses/MIT The MIT License
+ * @link       http://bootstrap.braincrafted.com Bootstrap for Symfony2
+ */
+class ButtonTypeExtension extends AbstractTypeExtension
+{
+    /**
+     * {@inheritDoc}
+     */
+    public function buildView(FormView $view, FormInterface $form, array $options)
+    {
+        $view->vars['button_class'] = $form->getConfig()->getOption('button_class');
+        $view->vars['as_link'] = $form->getConfig()->getOption('as_link');
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    public function setDefaultOptions(OptionsResolverInterface $resolver)
+    {
+        $resolver->setOptional(array('button_class', 'as_link'));
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    public function getExtendedType()
+    {
+        return 'button';
+    }
+}
\ No newline at end of file
diff --git a/Resources/config/services/form.xml b/Resources/config/services/form.xml
index b8165ac..050e45e 100644
--- a/Resources/config/services/form.xml
+++ b/Resources/config/services/form.xml
@@ -8,6 +8,7 @@
         <parameter key="braincrafted_bootstrap.form.type.money.class">Braincrafted\Bundle\BootstrapBundle\Form\Type\MoneyType</parameter>
         <parameter key="braincrafted_bootstrap.form.type.form_actions.class">Braincrafted\Bundle\BootstrapBundle\Form\Type\FormActionsType</parameter>
         <parameter key="braincrafted_bootstrap.form.extension.typesetter_extension.class">Braincrafted\Bundle\BootstrapBundle\Form\Extension\TypeSetterExtension</parameter>
+        <parameter key="braincrafted_bootstrap.form.extension.button_extension.class">Braincrafted\Bundle\BootstrapBundle\Form\Extension\ButtonTypeExtension</parameter>
         <parameter key="braincrafted_bootstrap.form.extension.input_group_button.class">Braincrafted\Bundle\BootstrapBundle\Form\Extension\InputGroupButtonExtension</parameter>
     </parameters>
 
@@ -29,6 +30,10 @@
             <tag name="form.type_extension" alias="form" />
         </service>
 
+        <service id="braincrafted_bootstrap.form.extension.form_action_button" class="%braincrafted_bootstrap.form.extension.button_extension.class%">
+            <tag name="form.type_extension" alias="button" />
+        </service>
+
         <service id="braincrafted_bootstrap.form.extension.input_group_button" class="%braincrafted_bootstrap.form.extension.input_group_button.class%">
             <tag name="form.type_extension" alias="text" />
         </service>
diff --git a/Resources/views/Form/bootstrap.html.twig b/Resources/views/Form/bootstrap.html.twig
index 2e58d77..a3cf85b 100644
--- a/Resources/views/Form/bootstrap.html.twig
+++ b/Resources/views/Form/bootstrap.html.twig
@@ -502,11 +502,15 @@
             {% set label = name|humanize %}
         {% endif %}
         {% if type is defined and type == 'submit' %}
-            {% set attr = attr|merge({ 'class': (attr.class|default('') ~ ' btn btn-'~attr.type|default('primary'))|trim }) %}
+            {% set attr = attr|merge({ 'class': (attr.class|default('') ~ ' btn btn-'~button_class|default('primary'))|trim }) %}
         {% else %}
-            {% set attr = attr|merge({ 'class': (attr.class|default('') ~ ' btn btn-'~attr.type|default('default'))|trim }) %}
+            {% set attr = attr|merge({ 'class': (attr.class|default('') ~ ' btn btn-'~button_class|default('default'))|trim }) %}
+        {% endif %}
+        {% if as_link is defined and as_link == true %}
+            <a {{ block('button_attributes') }}>{% if attr.icon is defined and attr.icon != '' %}{{ icon(attr.icon) }}{% endif %}{{ label|trans({}, translation_domain) }}</a>
+        {% else %}
+            <button type="{{ type|default('button') }}" {{ block('button_attributes') }}>{% if attr.icon is defined and attr.icon != '' %}{{ icon(attr.icon) }}{% endif %}{{ label|trans({}, translation_domain) }}</button>
         {% endif %}
-        <button type="{{ type|default('button') }}" {{ block('button_attributes') }}>{% if attr.icon is defined and attr.icon != '' %}{{ icon(attr.icon) }}{% endif %}{{ label|trans({}, translation_domain) }}</button>
     {% endspaceless %}
 {% endblock button_widget %}