Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uint32 Quota vs double FixedShareRatio #21

Open
average-gary opened this issue Apr 18, 2024 · 0 comments
Open

uint32 Quota vs double FixedShareRatio #21

average-gary opened this issue Apr 18, 2024 · 0 comments

Comments

@average-gary
Copy link
Contributor

Using Rust and using tonic::include_proto!("braiins.bos.v1");

Trying to generalize some ASIC configuration and go from FixedShareRatio into a general Quota by multiplying by 100 and such. Find this for f64 to u64 but Quota is u32, however other 64bit types are defined elsewhere, so I assume 64bit unsigned integers would be allowable.

Not really sure if this is an issue or not but seems like a general inconsistency.

proto/bos/v1/pool.proto

// Structure for quota load balance strategy
message Quota {
  uint32 value = 1;
}

// Structure for fixed share ratio load balance strategy
// Fixed share ratio is value between 0.0 to 1.0 where 1.0 represents that all work is
// generated from the group
message FixedShareRatio {
  double value = 1;
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant