Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove another special character to the hash #494

Merged
merged 2 commits into from
Jul 23, 2023
Merged

Conversation

baruchiro
Copy link
Collaborator

@baruchiro baruchiro commented Jul 23, 2023

Also, don't use yarn 3

@baruchiro baruchiro requested a review from brafdlog as a code owner July 23, 2023 05:45
@github-actions
Copy link
Contributor

Please fix the title of this PR.

Examples:

Breaking: I broke something
Fix: fix (fixes #1234)
Update: some packages updates (refs #123)
New: Added a new feature

See more in release.config.js.

@baruchiro baruchiro changed the title fix: remove another special character to the hash Fix: remove another special character to the hash Jul 23, 2023
@@ -132,5 +132,6 @@
},
"resolutions": {
"electron-builder": "^23.0.0"
}
},
"packageManager": "yarn@1.22.19"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why lock this version of yarn?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know 😱😱😱
I tried yarn version 3 in another project, but it was worst, and I tried to force using yarn classic but it returned back to version 3 every time, until I declared it here!

@baruchiro
Copy link
Collaborator Author

Tested and it worked

@baruchiro baruchiro merged commit 7df0fdf into master Jul 23, 2023
@baruchiro baruchiro deleted the special-char branch July 23, 2023 09:27
github-actions bot pushed a commit that referenced this pull request Jul 23, 2023
## [1.11.13](v1.11.12...v1.11.13) (2023-07-23)

### Fix

* remove another special character to the hash (#494) ([7df0fdf](7df0fdf)), closes [#494](#494)
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.11.13 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants