Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time in Dutch #316

Closed
1 task done
scola84 opened this issue Mar 28, 2024 · 0 comments · Fixed by #317
Closed
1 task done

Time in Dutch #316

scola84 opened this issue Mar 28, 2024 · 0 comments · Fixed by #317

Comments

@scola84
Copy link

scola84 commented Mar 28, 2024

Cron Expression
30 5 * * *

Expected Output
"Om 05:30"

Actual Output
"Op 05:30"

Prerequisites

  • The cron expression being passed in is a valid expression. cRonstrue does not validate expressions and assumes the one you pass is already valid. See the FAQ for more details.

In Dutch when referring to a time we say "Om" and not "Op". In the German locale I see "Um", which is correct. So where the German locale says "Um" the Dutch locale should say "Om".

at: https://github.com/bradymholt/cRonstrue/blob/main/src/i18n/locales/nl.ts#L36
atSpace: https://github.com/bradymholt/cRonstrue/blob/main/src/i18n/locales/nl.ts#L30
atX0: https://github.com/bradymholt/cRonstrue/blob/main/src/i18n/locales/nl.ts#L69

Brilliant package!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant