[CLOSED] Detect pending text insertion when inserting from hint list

[core-ai-bot]

Issue by redmunds
Monday Sep 16, 2013 at 20:03 GMT
Originally opened as adobe/brackets#5228

---

This is for #5003.

CodeHintList now keeps track of pending text insertions so it can make a better decision about when to insert when it receives an Enter key.

---

redmunds included the following code: https://github.com/adobe/brackets/pull/5228/commits

[core-ai-bot]

Comment by redmunds
Wednesday Sep 18, 2013 at 03:34 GMT

---

@RaymondLim I pushed changes for all of your comments so far. I also found and fixed a typo that I copied and pasted in several places :)

I am still not sure about the question I asked about CodeHintList.js line 437, so don't merge yet. I was planning to ask in next standup meeting.

[core-ai-bot]

Comment by redmunds
Thursday Sep 26, 2013 at 23:49 GMT

---

Pushed changed for a much simpler fix. See comment in CodeHintList.js line 409 for details. This simplified fix means that there are no changes to HintProvider code, but I did leave in some cleanup I did to the comments -- let me know if I should remove those. Ready for another review.