[CLOSED] Fix issue 4778: Do not show Active Line Highlight when editor has selection

[core-ai-bot]

Issue by lkcampbell
Thursday Aug 22, 2013 at 16:55 GMT
Originally opened as adobe/brackets#4878

---

This fix hides the Active Line Highlight when there is a selection in the current editor.

It does not address the general delay with the Shift-Down-Arrow, a different problem that started showing up in the Dev version of Sprint 30. It does, however, remove the really, really slow behavior associated with the having the Highlight Active Line turned on. The delay should now be the same, regardless of the Highlight Active Line setting.

I'm not sure I should be setting the CodeMirror Option on every single call to cursorActivity, but I didn't notice any performance issues by doing so. Let me know if you want me to set a flag or something to avoid excessive setOption calls.

---

lkcampbell included the following code: https://github.com/adobe/brackets/pull/4878/commits

[core-ai-bot]

Comment by lkcampbell
Thursday Aug 22, 2013 at 17:01 GMT

---

This fix addresses Issue #4778 and part of Issue #3191.

[core-ai-bot]

Comment by peterflynn
Thursday Aug 22, 2013 at 17:55 GMT

---

@lkcampbell In the future, I was wondering if you could use more descriptive pull request titles. It makes it easier to scan our overall list of PRs, which shows very little of the description (or the RepoMan view we sometimes use, which shows none of the description). Similarly, GitHub issue link tooltips and the like only show the title.

[core-ai-bot]

Comment by lkcampbell
Thursday Aug 22, 2013 at 19:49 GMT

---

@peterflynn, I updated the description. Thanks for the input.

[core-ai-bot]

Comment by peterflynn
Thursday Aug 22, 2013 at 20:41 GMT

---

Thanks@lkcampbell! (Thanks for the fix here too btw :-)

[core-ai-bot]

Comment by RaymondLim
Friday Aug 23, 2013 at 02:48 GMT

---

Done with review.

[core-ai-bot]

Comment by lkcampbell
Friday Aug 23, 2013 at 13:29 GMT

---

@RaymondLim, pull request updated.

[core-ai-bot]

Comment by RaymondLim
Friday Aug 23, 2013 at 17:13 GMT

---

@lkcampbell
This pull request is failing one of the editor option handlers unit tests. Could you fix it?

should style active line after turning it on
  TypeError: Cannot call method 'hasSelection' of null

[core-ai-bot]

Comment by lkcampbell
Friday Aug 23, 2013 at 18:24 GMT

---

@RaymondLim, good catch! Sorry about that. I did run unit tests but I was on the Unit tab instead of the All tab and I completely missed it.

I will fix this tonight.