Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] Fix #4750: It still will switch language if you click the cancel button. #4394

Open
core-ai-bot opened this issue Aug 29, 2021 · 1 comment
Open

[CLOSED] Fix #4750: It still will switch language if you click the cancel button. #4394

core-ai-bot opened this issue Aug 29, 2021 · 1 comment

Comments

@core-ai-bot
Copy link
Member

Issue by TomMalbran
Monday Aug 12, 2013 at 09:01 GMT
Originally opened as adobe/brackets#4753

Fix #4750.

It should only change the language and reload the window when the OK button was pressed, since done only means that the dialog was closed, and not that was accepted.

TomMalbran included the following code: https://github.com/adobe/brackets/pull/4753/commits
@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Friday Aug 16, 2013 at 20:13 GMT

Looks good! Merging.

This was referenced Aug 29, 2021
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@core-ai-bot