[CLOSED] [OPEN] Update Less to 1.4.2

[core-ai-bot]

Issue by WebsiteDeveloper
Tuesday Jul 16, 2013 at 16:28 GMT
Originally opened as adobe/brackets#4476

---

---

WebsiteDeveloper included the following code: https://github.com/adobe/brackets/pull/4476/commits

[core-ai-bot]

Comment by gruehle
Wednesday Jul 17, 2013 at 20:18 GMT

---

@WebsiteDeveloper Thanks. Are you aware of any bugs in 1.4.1? I did some quick sanity testing with your branch and everything seemed okay.

[core-ai-bot]

Comment by WebsiteDeveloper
Wednesday Jul 17, 2013 at 21:11 GMT

---

@gruehle i am currently not aware of any bugs in 1.4.1. Actually i have been working with this branch a few days and didn't notice any bugs yet.

[core-ai-bot]

Comment by TuckerWhitehouse
Wednesday Jul 17, 2013 at 23:13 GMT

---

I've also been using the less 1.4.1 compiler for the past few days and haven't noticed any issues.

On another note, If you enabled the "strictMath" mode (which will be enabled by default in the future), the UI loads, but the sidebar is rather broken...

[core-ai-bot]

Comment by WebsiteDeveloper
Thursday Jul 18, 2013 at 05:30 GMT

---

@TuckerWhitehouse i think i'll look into that and open another subsequent pull request

[core-ai-bot]

Comment by WebsiteDeveloper
Wednesday Jul 31, 2013 at 18:17 GMT

---

@gruehle any news on this?

[core-ai-bot]

Comment by gruehle
Sunday Aug 04, 2013 at 00:47 GMT

---

@WebsiteDeveloper - Sorry, I've been out on vacation this week, and will be out next week, too. I'm going to tag this as [OPEN] to see if someone else can get this merged in before I return.

[core-ai-bot]

Comment by WebsiteDeveloper
Sunday Aug 04, 2013 at 06:48 GMT

---

@gruehle no problem :) enjoy your vacation.

[core-ai-bot]

Comment by WebsiteDeveloper
Sunday Sep 01, 2013 at 08:33 GMT

---

@gruehle are you in again?

[core-ai-bot]

Comment by redmunds
Tuesday Sep 03, 2013 at 14:44 GMT

---

@WebsiteDeveloper I can take a look at this one.

[core-ai-bot]

Comment by redmunds
Tuesday Sep 03, 2013 at 21:31 GMT

---

@WebsiteDeveloper I'm ready to review this one -- can you merge the latest master into your branch?

[core-ai-bot]

Comment by WebsiteDeveloper
Wednesday Sep 04, 2013 at 06:08 GMT

---

@redmunds merged with master.

[core-ai-bot]

Comment by redmunds
Wednesday Sep 04, 2013 at 18:54 GMT

---

This unit test is failing: Integration > Extension Utils > "should attach LESS style sheets":

Error: Expected '/* basic.less */
#project-title {
  font-size: 66px;
}
' to be '/* basic.less */
#project-title {
  font-weight: 800;
}
#project-title {
  font-size: 66px;
}
'.
    at new jasmine.ExpectationResult (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:102:32)
    at null.toBe (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1194:29)
    at null.<anonymous> (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/spec/ExtensionUtils-test.js:134:40)
    at jasmine.Block.execute (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1024:15)
    at jasmine.Queue.next_ (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1842:31)
    at onComplete (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1838:18)
    at jasmine.WaitsForBlock.execute (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:2322:5)
    at file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:2336:12

[core-ai-bot]

Comment by redmunds
Wednesday Sep 04, 2013 at 19:13 GMT

---

Done with initial review.

[core-ai-bot]

Comment by WebsiteDeveloper
Friday Sep 06, 2013 at 12:03 GMT

---

@redmunds by the way if i put an url around the current import line in basic.less.
like that url("sub dir/fourth.less"); the unit test don't fail anymore. This is very weird actually.

[core-ai-bot]

Comment by WebsiteDeveloper
Saturday Sep 07, 2013 at 06:44 GMT

---

@redmunds i pushed a few changes.

[core-ai-bot]

Comment by TomMalbran
Saturday Sep 07, 2013 at 17:14 GMT

---

@WebsiteDeveloper It looks like tou still need to merge with master and fix the conflict issues.

[core-ai-bot]

Comment by WebsiteDeveloper
Saturday Sep 07, 2013 at 18:13 GMT

---

@TomMalbran will do so thanks for the heads up.

[core-ai-bot]

Comment by WebsiteDeveloper
Saturday Sep 07, 2013 at 18:17 GMT

---

@redmunds@TomMalbran fixed merge conflict.

[core-ai-bot]

Comment by redmunds
Sunday Sep 08, 2013 at 00:45 GMT

---

@WebsiteDeveloper This is looking good, but there's a unit test failing in this branch that's not failing in master. Maybe just need to sync with master again?

Unit > HighlightAgent > "should toggle the highlight via a command"

Error: Expected spy showHighlight to have been called.
    at new jasmine.ExpectationResult (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:102:32)
    at null.toHaveBeenCalled (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1194:29)
    at null.<anonymous> (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/spec/LiveDevelopment-test.js:299:65)
    at jasmine.Block.execute (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1024:15)
    at jasmine.Queue.next_ (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1842:31)
    at jasmine.Queue.start (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1795:8)
    at jasmine.Spec.execute (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:2122:14)
    at jasmine.Queue.next_ (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1842:31)
    at jasmine.Queue.start (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1795:8)
    at jasmine.Suite.execute (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:2267:14)
    at jasmine.Queue.next_ (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1842:31)

[core-ai-bot]

Comment by WebsiteDeveloper
Monday Sep 09, 2013 at 12:35 GMT

---

@redmunds i couldn't figure it out until now. Just wanted to lett you know that i will be away until next week.
Maybe you can figure out whats the matter with the unit test, if you have some spare time ;)

[core-ai-bot]

Comment by redmunds
Wednesday Sep 11, 2013 at 23:20 GMT

---

@WebsiteDeveloper I'm hoping that is fixed with pull request adobe/brackets#5115, so try merging with latest master code before spending any time on it.

[core-ai-bot]

Comment by WebsiteDeveloper
Sunday Sep 15, 2013 at 09:55 GMT

---

@redmunds i fixed the unit test failure. this one just failed because less wasn't correctly included.

[core-ai-bot]

Comment by redmunds
Sunday Sep 15, 2013 at 16:49 GMT

---

@WebsiteDeveloper I'm also noticing a reference to 'src/thirdparty/less-1.3.3.min.js' in brackets/Gruntfile.js that needs to be updated. Thanks.

[core-ai-bot]

Comment by WebsiteDeveloper
Sunday Sep 15, 2013 at 19:53 GMT

---

@redmunds changes pushed.

[core-ai-bot]

Comment by redmunds
Monday Sep 16, 2013 at 14:30 GMT

---

Thanks! Merging.