[CLOSED] Directory creation error

[core-ai-bot]

Issue by thefirstofthe300
Saturday Jun 15, 2013 at 05:04 GMT
Originally opened as adobe/brackets#4244

---

I have two commits in this pull request because GitHub was being stupid and wouldn't let me make a pull request with my other branch.

This should fix issue #3985. I have checked it out on the Linux build so I am not a hundred percent sure but it appears to work just fine.

---

thefirstofthe300 included the following code: https://github.com/adobe/brackets/pull/4244/commits

[core-ai-bot]

Comment by jasonsanjose
Monday Jun 17, 2013 at 21:13 GMT

---

Initial review complete

[core-ai-bot]

Comment by thefirstofthe300
Friday Jun 28, 2013 at 06:01 GMT

---

I implemented all code suggestions and everything should work like a charm. :)

[core-ai-bot]

Comment by jasonsanjose
Tuesday Jul 09, 2013 at 21:21 GMT

---

@DaBungalow 3 more comments and we should be ready to merge.

[core-ai-bot]

Comment by thefirstofthe300
Tuesday Jul 09, 2013 at 23:10 GMT

---

How does this look?

[core-ai-bot]

Comment by jasonsanjose
Wednesday Jul 10, 2013 at 23:18 GMT

---

@DaBungalow 1 more comment. Please re-test.

[core-ai-bot]

Comment by thefirstofthe300
Wednesday Jul 10, 2013 at 23:37 GMT

---

@jasonsanjose I would do the testing myself but I am currently running Linux only and am not sure how to get the test suite running on Linux. Can you point me in the right direction?

Currently, all I see when I open SpecRunner.html is the title bar and nothing else.

Edit: Looking at the SpecRunner.js, it would appear that I need to have Node installed, but I know for a fact that I don't. How to integrate?

[core-ai-bot]

Comment by jasonsanjose
Wednesday Jul 10, 2013 at 23:50 GMT

---

You could test manually to catch that last issue I caught. It's not ideal, but if you also have access to a mac or win machine that would help too. As you know, there's still plenty of work to do on linux. You can help by implementing node integration :)

[core-ai-bot]

Comment by thefirstofthe300
Wednesday Jul 10, 2013 at 23:52 GMT

---

Not sure where to start to integrate Node. I don't have any experience
with it. But I will try. :)

On Wed, Jul 10, 2013 at 4:51 PM, Jason San Jose notifications@github.comwrote:

You could test manually to catch that last issue I caught. It's not ideal,
but if you also have access to a mac or win machine that would help too. As
you know, there's still plenty of work to do on linux. You can help by
implementing node integration :)

—
Reply to this email directly or view it on GitHubhttps://github.com/adobe/brackets/pull/4244#issuecomment-20781743
.

Danny Seymour
dannyseeless@gmail.com

[core-ai-bot]

Comment by thefirstofthe300
Thursday Jul 11, 2013 at 01:03 GMT

---

OK. I implemented all of the comments and tested this. On my Linux build, this works perfectly, so it should be good to merge.

[core-ai-bot]

Comment by jasonsanjose
Thursday Jul 11, 2013 at 03:37 GMT

---

One more comment@DaBungalow. Sorry I didn't catch that sooner.

[core-ai-bot]

Comment by thefirstofthe300
Thursday Jul 11, 2013 at 07:22 GMT

---

Is this what you are wanting?

[core-ai-bot]

Comment by jasonsanjose
Thursday Jul 11, 2013 at 17:21 GMT

---

Looks good. Thanks for your patience. Merging.