Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] Mac OSX 10.9 Support? #3905

Open
core-ai-bot opened this issue Aug 29, 2021 · 22 comments
Open

[CLOSED] Mac OSX 10.9 Support? #3905

core-ai-bot opened this issue Aug 29, 2021 · 22 comments

Comments

@core-ai-bot
Copy link
Member

Issue by ghost
Thursday Jun 13, 2013 at 20:58 GMT
Originally opened as adobe/brackets#4220

Just wondering if the team have starting testing with Maverick? If you guys haven't, I can start looking into things on it and stress-testing it and what-not.
@core-ai-bot
Copy link
Member Author

Comment by redmunds
Thursday Jun 13, 2013 at 21:06 GMT

@tomkilpatrick I haven't heard of anyone getting started on 10.9, so that be awesome! Thanks.

@core-ai-bot
Copy link
Member Author

Comment by ghost
Thursday Jun 13, 2013 at 22:47 GMT

Startup is slower than Win 7 by 2 or 3 seconds, but other than that everything seems to be working OK.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Friday Jun 14, 2013 at 23:09 GMT

Thanks, Tom. Did you do this testing with Brackets from an installer, or did you clone Brackets and do a local build of brackets-shell?

@core-ai-bot
Copy link
Member Author

Comment by ghost
Sunday Jun 16, 2013 at 07:59 GMT

I did it with an installer, however I can do a local build if you want the bleeding edge result?

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Monday Jun 17, 2013 at 15:01 GMT

I was more curious if there were any issues with building brackets-shell with Xcode on Mac 10.9.

@core-ai-bot
Copy link
Member Author

Comment by gruehle
Monday Jun 17, 2013 at 18:09 GMT

Reviewed, low priority to@redmunds

@core-ai-bot
Copy link
Member Author

Comment by ghost
Monday Jun 17, 2013 at 20:47 GMT

@redmunds Alright, I'll have a look into that soon. Anything else you want me to check whilst I'm at it?

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Tuesday Jun 18, 2013 at 16:07 GMT

That would be great. After you build on Mac 10.9, also be sure that you can run it :)

@core-ai-bot
Copy link
Member Author

Comment by ghost
Tuesday Jun 18, 2013 at 23:56 GMT

Everything works perfectly fine, built it without a sweat and it's runs fine.

Although, it does still lag on start-up. We're still tagging around that 0.7s-1.0s start-up time.

@core-ai-bot
Copy link
Member Author

Comment by njx
Tuesday Jun 18, 2013 at 23:57 GMT

Yeah, we haven't done any startup optimization yet--we aren't even doing things like precompiling/minifying our JS or LESS files. A long time ago I did a quick prototype of that and it improved startup time by about 20%--might be even more now.

@core-ai-bot
Copy link
Member Author

Comment by ghost
Wednesday Jun 19, 2013 at 00:35 GMT

@njx How'd you go about doing that? I may as well take a dive into that pool as well.

Strangely, the cloned ver. starts up quicker than the installer I downloaded from the Brackets site. I'm not too sure why that might be, so you guys might want to take a geez at that too. -T

@core-ai-bot
Copy link
Member Author

Comment by njx
Wednesday Jun 19, 2013 at 00:37 GMT

I just did it manually--ran the command-line LESS compiler and substituted in the built version, and used r.js to concatenate/minify all the core require modules (extensions would have to be dealt with separately; for now it's probably fine to just keep them unminified). The right thing to do would be to build all this into the grunt script, of course :)

@core-ai-bot
Copy link
Member Author

Comment by ghost
Wednesday Jun 19, 2013 at 00:47 GMT

Alright, I might look into that and see if it makes the start-up smoother. If it does, there must be a way to do that automatically. I'll investigate.

@core-ai-bot
Copy link
Member Author

Comment by TuckerWhitehouse
Saturday Aug 10, 2013 at 01:41 GMT

Just installed the last OS X 10.9 Preview (v5) and Xcode5-DP5, and can't compile brackets-shell. The grunt output is rather unhelpful (Error Code: 65), but the file it points to (appshell_extensions_mac.mm) appears to have a few issues when the project is opened in Xcode.

>> ** BUILD FAILED **
>> 
>> 
>> The following build commands failed:
>>  CompileC xcodebuild/appshell.build/Release/appshell_helper_app.build/Objects-normal/x86_64/appshell_extensions_mac.o appshell/appshell_extensions_mac.mm normal x86_64 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler
>> (1 failure)
>> Error code: 65
>> ** BUILD FAILED **
>> 
>> 
>> The following build commands failed:
>>  CompileC xcodebuild/appshell.build/Release/appshell_helper_app.build/Objects-normal/x86_64/appshell_extensions_mac.o appshell/appshell_extensions_mac.mm normal x86_64 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler
>> (1 failure)

The 5th argument being positionIdx, which is defined as an NSInteger and then supplied to the function which expects an int32. Changing the positionIdx definitions from NSInteger positionIdx = -1 to int32 positionIdx = -1, or typecasting the parameter (int &)positionIdx causes ~103 issues with the appshell_helper_app related to _cef. Not sure if anybody else has experienced these issues? Unfortunately my experience with C is rather limited.

screen shot 2013-08-09 at 8 49 18 pm

@core-ai-bot
Copy link
Member Author

Comment by ingorichter
Friday Sep 20, 2013 at 22:16 GMT

Yes, I saw this issue too.

@core-ai-bot
Copy link
Member Author

Comment by ingorichter
Friday Sep 20, 2013 at 22:17 GMT

Since the compile issues happen on 10.8.x too, I don't think that this a 10.9 only issues anymore.

@core-ai-bot
Copy link
Member Author

Comment by martineno
Saturday Sep 21, 2013 at 05:26 GMT

I dug into this a little bit and as far as I can tell it seems like XCode 5 defaults to 64-bit target. So when you make the changes that are mentioned by@TuckerWhitehouse and recompile you get bunch of linking errors that complain about architecture (the share library is compile for i386 and the linker is trying to link it with x86_64).

My XCode wrangling skills are weak, but to my inexpert eyes it looks like changing the xcodeproject file to 32-bit target might fix the issue.

@core-ai-bot
Copy link
Member Author

Comment by cfjedimaster
Sunday Sep 22, 2013 at 11:49 GMT

Just chiming in that I ran into this as well. OSX 10.8.X with XCode 5 installed (final version).

@core-ai-bot
Copy link
Member Author

Comment by TuckerWhitehouse
Sunday Sep 22, 2013 at 18:16 GMT

On OS X 10.8.5 with XCode 5, I have no trouble compiling.

If i'm not mistaken, chrome is 32-bit only, so attempting to compile as a 64-bit, as mentioned by@martineno, could be what is causing all these issues.

@core-ai-bot
Copy link
Member Author

Comment by cfjedimaster
Sunday Sep 22, 2013 at 19:25 GMT

I just switched my XCode back to 4.(um, whatever it was) and it worked fine after that.

@core-ai-bot
Copy link
Member Author

Comment by TuckerWhitehouse
Wednesday Sep 25, 2013 at 21:31 GMT

Possible Fixes #5328

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Wednesday Oct 09, 2013 at 16:44 GMT

The Xcode 5 issue was fixed with pull adobe/brackets-shell#338, so closing this one.

@core-ai-bot core-ai-bot mentioned this issue Aug 29, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@core-ai-bot