[CLOSED] Order of OK and Cancel buttons is reversed

[core-ai-bot]

Issue by redmunds
Tuesday Jun 04, 2013 at 20:58 GMT
Originally opened as adobe/brackets#4091

---

Before the update, dialog buttons were right-aligned, so you had to specify them in the reverse order of how you wanted them to appear. That seems to have changed (although buttons are still right-aligned) because the order of buttons is the reverse of what it was before.

Also, there is no longer any margin between buttons.

[core-ai-bot]

Comment by njx
Tuesday Jun 04, 2013 at 21:06 GMT

---

Hmmm, interesting. Right now, it looks like on the Mac the buttons in the Project Settings dialog are in the right order (Cancel / OK), but they're in the wrong order in the Install from URL dialog (Install / Cancel). So there's some additional inconsistency in how we're setting up the order.

[core-ai-bot]

Comment by TomMalbran
Tuesday Jun 04, 2013 at 21:44 GMT

---

The Dialogs Buttons order was changed by my request #3086 in order to fix #3077 and #1089. The buttons are aligned to the right instead of floated, so that they can be added in the correct order, and in Windows the order of the Cancel/OK is reversed by floating them to the right. It seems like I missed a change to the Install from Url Dialog.

[core-ai-bot]

Comment by njx
Tuesday Jun 04, 2013 at 22:14 GMT

---

Ah, ok.@redmunds - do the buttons in all the other dialogs (besides Install from URL) look correct on Windows?

[core-ai-bot]

Comment by redmunds
Tuesday Jun 04, 2013 at 23:03 GMT

---

I'm also seeing it in prompts for unsaved changes for single and multiple files, so it seems to effect all templated modal dialogs that have both OK and Cancel buttons.

[core-ai-bot]

Comment by jasonsanjose
Wednesday Jun 05, 2013 at 18:22 GMT

---

I removed the [framework-update] tag in the title now that we've narrowed it down to the Dialogs API changes. Assigned@jasonsanjose.

[core-ai-bot]

Comment by TomMalbran
Thursday Jun 06, 2013 at 01:14 GMT

---

Some notes about this issue:

• The change of the order of the buttons was intentional to fix the issues mentioned above.
• The buttons in the Install from Url Dialog are now in the wrong order and need to be fixed. I checked with the other dialogs and they all seem to be ok. The fix for this is really simple.
• Since only the second and third buttons have a margin left, on some dialogs with just 2 right buttons like the Project Settings one, the first button doesn't get a margin left, so when inverted there is no space between the buttons.

From what I get, fixing this last 2 things would fix this issue, so I'll try to make a pull request for that.

[core-ai-bot]

Comment by redmunds
Thursday Jun 06, 2013 at 02:17 GMT

---

The buttons in the Install from Url Dialog are now in the wrong order and need to be fixed.
I checked with the other dialogs and they all seem to be ok.

Maybe I misunderstood, but all of the dialogs that I mentioned are still have the ok/cancel buttons in the wrong order. I also noticed the buttons in the Remove Extension info message dilaog are also in the wrong order.

[core-ai-bot]

Comment by TomMalbran
Thursday Jun 06, 2013 at 02:46 GMT

---

Right now on Mac the order of the buttons is normal then primary (Cancel and then OK), that is the same order as buttons in the templates. To fix issue #1089, on Windows the order of the buttons is primary and then normal (OK and then Cancel). So in windows all the buttons should be switched and on Mac should be as before. The issue #1089 only mentioned the save buttons, but the order of the buttons on Windows is usually Accept and then Cancel, so I fixed it for all the buttons.

[core-ai-bot]

Comment by jasonsanjose
Thursday Jun 06, 2013 at 18:14 GMT

---

Confirmed fixed.