[CLOSED] Adding Handlebars file extension .hbs to use html syntax

[core-ai-bot]

Issue by tcarlsen
Thursday May 02, 2013 at 10:09 GMT
Originally opened as adobe/brackets#3699

---

---

tcarlsen included the following code: https://github.com/adobe/brackets/pull/3699/commits

[core-ai-bot]

Comment by jbalsas
Thursday May 02, 2013 at 11:06 GMT

---

@tcarlsen Should we also support .handlebars?

[core-ai-bot]

Comment by tcarlsen
Thursday May 02, 2013 at 11:17 GMT

---

@jbalsas to be honest I did't realize that people was using that extension ??? hbs is so sort and good looking, byt if many people is using the longer extension version, when yes it should be added

[core-ai-bot]

Comment by jbalsas
Thursday May 02, 2013 at 11:54 GMT

---

I was just curious, since I've seen it mentioned in some tutorials, mostly in reference to precompiling templates. (http://handlebarsjs.com/precompilation.html) This is just a convention, so we may well ignore it, but it would look weird if we support one but not the other.

Would you like to add it?

[core-ai-bot]

Comment by jbalsas
Thursday May 02, 2013 at 16:12 GMT

---

@tcarlsen This looks good, but it breaks one test in test/spec/LanguageManager-test.js. It should be fairly easy to fix, and then we're good to go :)

Btw, new commits do not trigger the email notifications, so make sure to ping whoever's reviewing your pull requests to let him know that there's new stuff to look into.

[core-ai-bot]

Comment by tcarlsen
Friday May 03, 2013 at 07:22 GMT

---

sry@jbalsas for forgetting the test. Now its here and I did run a test me self and all is good :)

[core-ai-bot]

Comment by jbalsas
Friday May 03, 2013 at 16:48 GMT

---

No problem,@tcarlsen! Looking good now, thanks!

Merging