[CLOSED] KeyBindingManager methods should take a command

[core-ai-bot]

Issue by njx
Thursday Nov 08, 2012 at 01:24 GMT
Originally opened as adobe/brackets#2078

---

Most API functions that take a commandId can also take a command instead, but the KeyBindingManager methods only take a commandId.

[core-ai-bot]

Comment by pthiess
Thursday Nov 15, 2012 at 17:22 GMT

---

Reviewed assigned to@redmunds

[core-ai-bot]

Comment by redmunds
Wednesday Mar 06, 2013 at 04:15 GMT

---

I added the Starter Bug tag. Even though this is assigned to me, anyone is welcome to take this one.

[core-ai-bot]

Comment by lkcampbell
Wednesday Mar 06, 2013 at 20:37 GMT

---

I'm working on a fix for this bug.

[core-ai-bot]

Comment by lkcampbell
Wednesday Mar 06, 2013 at 21:36 GMT

---

Do you want me to try and write some new unit tests as well?

Right now, I am just focusing on not breaking the existing tests :).

[core-ai-bot]

Comment by redmunds
Wednesday Mar 06, 2013 at 21:43 GMT

---

You don't need to duplicate all of the other tests, but we should have at least 1 test for passing a Command.

[core-ai-bot]

Comment by lkcampbell
Thursday Mar 07, 2013 at 00:47 GMT

---

One quick question on any of these fixes I do. I am using the Whitespace Normalizer extension on Brackets which automatically cleans up whitespace on any file I touch.

Do you guys want me to do this? Is it helpful or does it made the diffs and code more difficult to maintain?

[core-ai-bot]

Comment by peterflynn
Thursday Mar 07, 2013 at 02:50 GMT

---

@lkcampbell My 2c is that it's better not to do that cleanup. If definitely adds to the diffs, and whitespace on blank lines is permitted by our style guide -- maybe even desired, since it makes the cursor jump around less as you navigate across lines. We actually did a bunch of work to turn off JSLint warnings for such lines so we could have them in our code.

Trailing whitespace on non-blank lines is a minor annoyance though, so it's ok by me to clean up cases like that.

[core-ai-bot]

Comment by lkcampbell
Thursday Mar 07, 2013 at 03:45 GMT

---

@peterflynn Sounds good to me. I'm not fond of the jumpy cursor either.

I will throw the empty line white space back in and avoid cleanups in the future.

[core-ai-bot]

Comment by redmunds
Monday Mar 11, 2013 at 21:01 GMT

---

Confirmed. Closing.