Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using eslint + prettier #13833

Open
core-ai-bot opened this issue Aug 31, 2021 · 2 comments
Open

Consider using eslint + prettier #13833

core-ai-bot opened this issue Aug 31, 2021 · 2 comments

Comments

@core-ai-bot
Copy link
Member

Issue by humphd
Sunday Apr 09, 2017 at 23:12 GMT
Originally opened as adobe/brackets#13290


In our Mozilla fork, we're thinking to move to using prettier via eslint to autoformat the code. I'm working with lots of new contributors, and trying to get them to style commits properly is a losing battle. I'm of the mind that doing this with tooling is the better way going forward.

Before we do it, I thought I'd see if you had interest here first; if so, it will make merging easier. Since you've not switched to eslint, this might make sense.

If it doesn't hold interest for you, let me know and we can close this.

@core-ai-bot
Copy link
Member Author

Comment by petetnt
Monday Apr 10, 2017 at 11:04 GMT


Actually we have already switched to eslint a long while back and I wouldn't have any issues myself to use prettier in combination too. 👍

@core-ai-bot
Copy link
Member Author

Comment by humphd
Thursday Apr 13, 2017 at 13:59 GMT


@dsych is starting this work in mozilla/brackets#703. I made a compare branch to show the effect of running grunt eslint using prettier to fix problems. There are some things here that need to be adjusted (e.g., 4-spaces vs. 2, fix javadoc style comment blocks, etc) but everything is configurable. Feel free to chime in with any suggestions on how the configuration should look.

Should I have him move this PR here, or keep it in ours?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant