Issue with Menu Bar rendered wrong, swap to title... High DPI Issues... Visual Error Win 7 Enterprise build 1.5.0-16538

[core-ai-bot]

Issue by tbaker4802
Sunday Oct 18, 2015 at 22:15 GMT
Originally opened as adobe/brackets#11838

---

Issues caused by high dpi in windows 7 , and possibly other versions

I started writing this issue request early today, however as the day progressed, i looked into it further and further, and believe i found the fix. I'm sorry for this ridiculously long post, however, I'll put in a pull request with the code hopefully by end of day (i have to run for now but wanted to post this first)

I believe I fixed the High DPI issues in windows 7, and while i haven't tested in windows 8 8.1 or 10, it should support per monitor scaling as well It also fixes the menu function that is described.

I've tried to lay out step by step how i came to the conclusions i have and also included the code examples and screenshots of how I made it all work correctly on my system with a 4k screen, and custom theme, using win blinds and other star dock software.

I apologize if there's grammatical errors and etc, I didn't have time to re edit this.

there are still very few small issues but i think from this you can get it worked out.

I like brackets and the things have been bugging me for a while, so i figured I'd work on it. Hopefully this is the right venue for posting this.

If you have any questions please reply. Thanks!

Issues addressed in this post:

• Issues with menu and title bar and inability to place or render menu and title in same field.
• High DPI Compatabilty and virtual scaling
  • application manifest issues
  • Issues with system metrics functionality
  • issues with dynamic dpi changes and dpi awareness levels

Issue with menu bar in Windows

I'm having an issue with the menu bar being non selectable. This has been encountered in past, and,
I've found similar issues, and so my concern is that while it may be being caused by extensions, it may in fact be a core brackets issue.

When I try to click on the menu bar (file edit etc...) It acts as though it is the title bar and acts to minimize or maximize when double clicked. Obviously that was annoying so I tried a few things and finally realized that when I mouse over top left corner of title bar, I get the menu bar.

---

General Information About Issue:

Screen Cast Of Issue:

A. The Menu Can not be clicked on the Menu Bar.

1. The menubar is acting as the title bar.
2. The menubar items do highlight on mouseover as described in point 2.

   B. If I mouseover the top left hand corner of the window (on title bar) the "file" menu button appears but in the title bar.

3. Menu can be clicked when it appears in title, and works
   a. _ ONLY THE FILE MENU APPEARS AND ONLY FILE CAN BE CLICKED
4. After "FILE" appears, you can mouse to the right, and the rest of the menu items appear.
5. The items in the menubar do not disappear as the "Title bar menu" appears.
6. You can not click on the menu bar items after getting the title bar menu, it still acts as title bar.
7. You can also access the menu by pressing the alt key and using the arrows
   a. _ When you use the arrows all menu items appear in title bar.

   C. Other random observations:

   a. "File" only appears on mouseover when windows is active.
   b. It does not matter if I uninstall all my add-ons.
   c. It does not matter if I have the window maximized or minimized.
   d. I checked preferences file, found no issues.
   e. Issue disappears if i uninstall the update and reinstall to old version.
   d. Issue re-appears when new version is installed again.

Info about what I did try as far as debugging this and why

Environmental Variables

Variable	My Environment
Operating System	Windows 7 Ultimate SP 1
Brackets Release	Release 1.5
Brackets Build	build 1.5.0-16538
Release Number	release cf9cf4698
Build Timestamp	Wed Oct 14 2015 15:08:37 GMT+0100

Other Maybe Relevant Info On My PC

Attribute	Value	Why relevant
Resolution	3840 x 2160	Issues others had relating to High DPI
3rd Party Software	Object Desktop By Stardock	Issues others had with star dock software
3rd Party Software	Windows Blinds 8 By Stardock	Issues others had with star dock software
3rd Party Software	Windows FX 6 By Stardock	Issues others had with star dock software
3rd Party Software	Tiles By Stardock	Issues others had with star dock software
Poss. Software Conflict	Google Chrome	Recently Uninstalled due to new security policies
Poss. Software Conflict	Mozilla Firefox	Started Using Firefox
Recent Extensions	NONE	Could cause conflict

Where are the brackets files on my computer?

Brackets Directory	Files Description	Notes
C:\Users\USER\AppData\Local\APPLIC1\APPLIC1\APPLIC1\APPLIC1\APPLIC1\APPLIC1\APPLIC1\APPLIC1\APPLIC1\APPLIC1\APPLIC1\APPLIC1\APPLIC1\APPLIC1\APPLIC1\APPLIC1\Temp\bracketsPackage_115918-2768-vxqjnf\adobe.brackets.extract	Seems to be temp extract extension files	WHAT IS DEAL WITH ALL THE APPLICATION DATA FOLDERS?

Extensions Installed In Brackets

Name	Version	Notes
Recent Extensions	NONE	Could cause conflict
Brackets Extension	Adobe Extract	Is Having An Error See Ref 1
Operating System	Windows 7 Ultimate SP 1
Brackets Release	Release 1.5
Brackets Build	build 1.5.0-16538
Release Number	release cf9cf4698
Build Timestamp	Wed Oct 14 2015 15:08:37 GMT+0100

---

Research other issues on Brackets Git Hub

What Fixes were tried and were any found?

Issue Number	Description	Applicable?	Why	Helpful with my menu title issue	If Yes, What?
#10073	Window z-index layering issue	[x]	Because seems to be issue with win api/ how frames are built.	[ ]	N/A
https://trello.com/c/WRhZ0xvj/969-high-dpi-support-on-windows-and-linux#	High DPI Support on Windows and Linux	[ ]	only addresses font scaling	[ ]	N/A
#9811	Menu & Tree Font Settings	[x]	shows me info about menu	[ ]	useless, closed as dup of highdpi thread
#10256	Random visual glitches around the menu area v1.1 (Win 7)	[x]	Info of win 7 and problems near menu	[x]	info about another win7 and menu issue
#8890	Mouse move within menu label causes flicker of menu text	[x]	More Problems near menu text	[x]	Similar Issues.
#9929	Main menu items get displaced on mouse hove	[x]	high dpi menu bar problem	[x]	Very similar issue

---

5. Personal Notes about Issue 11780 (request to merge menubar onto titlebar)

a. If this feature is added, it needs to have a preference flag to turn it off, I for one don't want it.
b. suggest using the name of "UI.Menu.Title.Merged.Bar": false, 

Errors Found In JS

I found notes inside of brackets developer add on that had a flag on a js file relating to extract extension

[Extension] failed to load C:/Users/Designer/AppData/Roaming/Brackets/extensions/user/adobe.brackets.extract - ReferenceError: _ is not defined
2
[CodeInspection] Provider standard (async) failed: undefined
2
[CodeInspection] Provider gjslint (async) failed: 'python' is not recognized as an internal or external command,
operable program or batch file.
Exception in 'queryChange' listener on
Exception in 'queryChange' listener on
''''
### Errors Found in 

[core-ai-bot]

Comment by abose
Monday Oct 19, 2015 at 09:29 GMT

---

Thanks@tbaker4802 for analyzing this in detail and reporting.

HiDpi support in Windows is pretty basic as we are still on Windows 7 API's for HiDpi support, and that does not support per monitor DPI scaling. 3840 x 2160 is a resolution in windows that we have not tested for Hidpi yet. But as these resolutions become much more common, we will have to prioritize this issue. To enable true HiDpi support in Windows, we need to update brackets-shell to 8.1 SDK which would take considerable effort. If you are interested in contributing to this effort, Please check out the brackets-shell repo that holds the native shell related code for HiDPI.

Brackets draw its own custom dark window chrome. The coordinates it gets may be broken with unexpected scale factors- which might be leading to the menu bar draw issues. Needs further investigation.

Linux is an altogether different issue, The current version of CEF for the Linux side of brackets-shell does not support HiDpi. adobe/brackets-shell#499 is the PR submitted to include CEF 2171 which has HiDpi support among other things. But but to lack of support from the Linux community, this has been stuck there for a while.