Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Fix of not picking file modifications. #10588

Open
core-ai-bot opened this issue Aug 30, 2021 · 12 comments
Open

[CLOSED] Fix of not picking file modifications. #10588

core-ai-bot opened this issue Aug 30, 2021 · 12 comments

Comments

@core-ai-bot
Copy link
Member

Issue by mfatekho
Friday Apr 08, 2016 at 16:41 GMT
Originally opened as adobe/brackets#12353


Inapproriate use of win api in fs_even_node module. In fsevents_win.cpp there are a thread that monitors file system events queue and post messages to uv library. Proposed solution is to use extra bool variable in THREADINFO structure to control thread exit state
@busykai


mfatekho included the following code: https://github.com/adobe/brackets/pull/12353/commits

@core-ai-bot
Copy link
Member Author

Comment by busykai
Monday Apr 11, 2016 at 20:59 GMT


@peterflynn,@bchintx,@abose: we were able to reproduce the filewatchers going offline. we expect this is supposed to fix #7638 and related issues. The issue occurs when some other tools interferes with the same file(s) causing "spurious" messages which result in this condition resolves to FALSE and causes the filewatchers to quit abruptly.

The fix consists of keeping an internal flag of whether the filewatchers should quit instead of relying on specific parameters of the "terminate" message.

@core-ai-bot
Copy link
Member Author

Comment by busykai
Wednesday Apr 13, 2016 at 15:57 GMT


LGTM. Will merge soon after the copyright is fixed.

@core-ai-bot
Copy link
Member Author

Comment by swmitra
Thursday Apr 14, 2016 at 08:13 GMT


LGTM 👍

@core-ai-bot
Copy link
Member Author

Comment by MiguelCastillo
Thursday Apr 14, 2016 at 13:36 GMT


This looks good to me. Totally got PTSD from old C++ days... :D

@core-ai-bot
Copy link
Member Author

Comment by ingorichter
Thursday Apr 14, 2016 at 21:40 GMT


Looks like a simple fix to get rid of the problem.

@core-ai-bot
Copy link
Member Author

Comment by bchintx
Thursday Apr 14, 2016 at 23:14 GMT


Please don't merge quite yet. Please see my comment inline above, as I think there's still a logic error that will prevent the fix from working as expected.

@core-ai-bot
Copy link
Member Author

Comment by ingorichter
Thursday Apr 14, 2016 at 23:17 GMT


@bchintx I was thinking about getting rid of bContinue, but you said it way better than I could have done this. ;-)

@core-ai-bot
Copy link
Member Author

Comment by mfatekho
Wednesday Apr 27, 2016 at 13:14 GMT


Hi guys,
Refactored code a little due to your recommendations. As you suggested, I have removed bContinue variable and wrapped ReadDirectoryChangesW to if.

@core-ai-bot
Copy link
Member Author

Comment by ingorichter
Wednesday May 04, 2016 at 21:41 GMT


Poking@bchintx to have another look.

@core-ai-bot
Copy link
Member Author

Comment by bchintx
Wednesday May 04, 2016 at 23:46 GMT


Looks good to me. Merging!

Nice work@mfatekho!

@core-ai-bot
Copy link
Member Author

Comment by busykai
Thursday May 05, 2016 at 15:55 GMT


Yay! Thanks@mfatekho and@evgen48 for root-causing and fixing this!

@core-ai-bot
Copy link
Member Author

Comment by MegaArman
Wednesday Sep 23, 2020 at 03:21 GMT


Just trying out brackets for the first time today. Here's my trouble scenario:
-have some files open
-git checkout in my terminal
-the files are not reloaded automatically nor am I prompted to reload them
-Write some code
-Hit ctrl-s and now I am given a dialogue window if I want to overwrite what's on disc. This is an issue because now I have to figure out if my changes to the file are actually OK

In the Geany editor under Edit->Preferences->Files-> Disc check timeout, you can set how often the disk is checked and it will prompt you to reload the file if changes are detected

Is there something like that for Brackets?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant