-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLOSED] Fix of not picking file modifications. #10588
Comments
Comment by busykai
The fix consists of keeping an internal flag of whether the filewatchers should quit instead of relying on specific parameters of the "terminate" message. |
Comment by busykai LGTM. Will merge soon after the copyright is fixed. |
Comment by swmitra LGTM 👍 |
Comment by MiguelCastillo This looks good to me. Totally got PTSD from old C++ days... :D |
Comment by ingorichter Looks like a simple fix to get rid of the problem. |
Comment by bchintx Please don't merge quite yet. Please see my comment inline above, as I think there's still a logic error that will prevent the fix from working as expected. |
Comment by ingorichter
|
Comment by mfatekho Hi guys, |
Comment by ingorichter Poking |
Comment by bchintx Looks good to me. Merging! Nice work |
Comment by busykai Yay! Thanks |
Comment by MegaArman Just trying out brackets for the first time today. Here's my trouble scenario: In the Geany editor under Edit->Preferences->Files-> Disc check timeout, you can set how often the disk is checked and it will prompt you to reload the file if changes are detected Is there something like that for Brackets? |
Issue by mfatekho
Friday Apr 08, 2016 at 16:41 GMT
Originally opened as adobe/brackets#12353
Inapproriate use of win api in fs_even_node module. In fsevents_win.cpp there are a thread that monitors file system events queue and post messages to uv library. Proposed solution is to use extra bool variable in THREADINFO structure to control thread exit state
@
busykaimfatekho included the following code: https://github.com/adobe/brackets/pull/12353/commits
The text was updated successfully, but these errors were encountered: