Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove execute_and_save function #84

Open
3 tasks
tkv29 opened this issue Apr 8, 2024 · 0 comments
Open
3 tasks

Remove execute_and_save function #84

tkv29 opened this issue Apr 8, 2024 · 0 comments

Comments

@tkv29
Copy link
Collaborator

tkv29 commented Apr 8, 2024

Description:
This tasks inlcudes the removal of the execute_and_save function. With the removal we only have one execute function, so we dont need the if the statements to run thee modules which have the execute_and_save function. For that we need to change the primary key schema. Currently the execute_and_save functions returns an int, so later when we are saving the results to db we can make the connection between the results. We can avoid that by using predefined primary keys which are following a specifc schema, so we dont need to return an int and can pass a dataframe.

Acceptance Criteria

  • defining pre-defined primary key schema where necessary
  • changing current int primary keys to predefined schema
  • replace execute_and_save with execute method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants