Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow create-append-anything to be easily disabled #1862

Closed
3 tasks done
smbea opened this issue Mar 7, 2023 · 4 comments
Closed
3 tasks done

Allow create-append-anything to be easily disabled #1862

smbea opened this issue Mar 7, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@smbea
Copy link
Contributor

smbea commented Mar 7, 2023

Is your feature request related to a problem? Please describe.

There is currently ways to remove the create-append-anything feature (see forum). But they require some effort or aren't super straightforward.

We should provide a way to easily remove create-append-anything.

Describe the solution you'd like

Extract create-append-anything to separate extension.

Describe alternatives you've considered

Don't ship it with default Modeler. Users have to explicitly add it if they want to use it.

Additional context

There have been around 4 (or more) questions on how to disable this feature. It is clear that not all users want this.

@smbea smbea added enhancement New feature or request backlog Queued in backlog labels Mar 7, 2023
@smbea smbea self-assigned this Mar 7, 2023
@smbea
Copy link
Contributor Author

smbea commented Mar 10, 2023

I like the config option because it still makes the feature discoverable but easy to remove.

We could check the Modeler options and remove the module if createAppendAnything = false (https://github.com/bpmn-io/bpmn-js/blob/develop/lib/Modeler.js#L135), similar to what we did in camunda-bpmn-js.

@nikku
Copy link
Member

nikku commented Mar 10, 2023

What about the alternative: Making it an external module (an extension)? Would fit nicely into our existing story, too.

@smbea
Copy link
Contributor Author

smbea commented Mar 10, 2023

You mean a completely separate extension living in a different library? Or a module that lives inside bpmn-js but is not added as default.

The reason I liked the option above was because it's easily discoverable, whilst something that is hidden in bpmn-js may not be as much. But it is less clean code wise.

A completely separate extension would be basically the connectors extension, right? We would extract the create-append-anything module and potentially allow to set templates too (based on our previous conversation, it's something we want to provide outside of camunda-bpmn-js)

@nikku
Copy link
Member

nikku commented Mar 10, 2023

A completely separate extension would be basically the connectors extension, right?

Exactly.

If possible we should keep the core lean. The readme ("related") and/or our awesome list are places to discover these additional helpful extensions.

@smbea smbea added the ready Ready to be worked on label Mar 21, 2023 — with bpmn-io-tasks
@smbea smbea removed the backlog Queued in backlog label Mar 21, 2023
@smbea smbea closed this as completed Mar 23, 2023
@bpmn-io-tasks bpmn-io-tasks bot removed the ready Ready to be worked on label Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants