From 32b4b2ec8acf8dc5e5eca4efbf6ed0ad6be3c3de Mon Sep 17 00:00:00 2001 From: Daniel Richards Date: Fri, 19 Jul 2024 12:28:27 +0800 Subject: [PATCH] Downgrade node 22(.5) unit tests to 22.4 (#63728) * Downgrade node 22 unit tests to 22.4 until https://github.com/npm/cli/issues/7657 is fixed * try again * Try using a stable name for the tests so that required jobs do not require an update --- .github/workflows/create-block.yml | 10 +++++++--- .github/workflows/unit-test.yml | 20 ++++++++++++++------ 2 files changed, 21 insertions(+), 9 deletions(-) diff --git a/.github/workflows/create-block.yml b/.github/workflows/create-block.yml index 0de1b9ee6566ae..245b136ee22c18 100644 --- a/.github/workflows/create-block.yml +++ b/.github/workflows/create-block.yml @@ -14,13 +14,17 @@ concurrency: jobs: checks: - name: Checks w/Node.js ${{ matrix.node }} on ${{ matrix.os }} + name: Checks w/Node.js ${{ matrix.node.name }} on ${{ matrix.os }} runs-on: ${{ matrix.os }} if: ${{ github.repository == 'WordPress/gutenberg' || github.event_name == 'pull_request' }} strategy: fail-fast: false matrix: - node: ['20', '22'] + node: + - name: 20 + version: 20 + - name: 22 + version: 22.4 os: ['macos-latest', 'ubuntu-latest', 'windows-latest'] steps: @@ -31,7 +35,7 @@ jobs: - name: Setup Node.js and install dependencies uses: ./.github/setup-node with: - node-version: ${{ matrix.node }} + node-version: ${{ matrix.node.version }} - name: Create block shell: bash diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index 488f41c217e7c2..75a0d34ddc8d87 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -21,13 +21,17 @@ concurrency: jobs: unit-js: - name: JavaScript (Node.js ${{ matrix.node }}) ${{ matrix.shard }} + name: JavaScript (Node.js ${{ matrix.node.name }}) ${{ matrix.shard }} runs-on: ubuntu-latest if: ${{ github.repository == 'WordPress/gutenberg' || github.event_name == 'pull_request' }} strategy: fail-fast: false matrix: - node: ['20', '22'] + node: + - name: 20 + version: 20 + - name: 22 + version: 22.4 shard: ['1/4', '2/4', '3/4', '4/4'] steps: @@ -39,7 +43,7 @@ jobs: - name: Setup Node.js and install dependencies uses: ./.github/setup-node with: - node-version: ${{ matrix.node }} + node-version: ${{ matrix.node.version }} - name: Determine the number of CPU cores uses: SimenB/github-actions-cpu-cores@97ba232459a8e02ff6121db9362b09661c875ab8 # v2.0.0 @@ -60,13 +64,17 @@ jobs: --cacheDirectory="$HOME/.jest-cache" unit-js-date: - name: JavaScript Date Tests (Node.js ${{ matrix.node }}) + name: JavaScript Date Tests (Node.js ${{ matrix.node.name }}) runs-on: ubuntu-latest if: ${{ github.repository == 'WordPress/gutenberg' || github.event_name == 'pull_request' }} strategy: fail-fast: false matrix: - node: ['20', '22'] + node: + - name: 20 + version: 20 + - name: 22 + version: 22.4 steps: - name: Checkout repository @@ -77,7 +85,7 @@ jobs: - name: Setup Node.js and install dependencies uses: ./.github/setup-node with: - node-version: ${{ matrix.node }} + node-version: ${{ matrix.node.version }} - name: Determine the number of CPU cores uses: SimenB/github-actions-cpu-cores@97ba232459a8e02ff6121db9362b09661c875ab8 # v2.0.0