Skip to content
This repository has been archived by the owner on Dec 2, 2020. It is now read-only.

gcc48 brew calling Formula.sha1 #98

Closed
dkowis opened this issue Dec 19, 2016 · 9 comments
Closed

gcc48 brew calling Formula.sha1 #98

dkowis opened this issue Dec 19, 2016 · 9 comments

Comments

@dkowis
Copy link

dkowis commented Dec 19, 2016

Error: Calling Formula.sha1 is disabled!
Use Formula.sha256 instead.
/opt/boxen/homebrew/Library/Taps/boxen/homebrew-brews/gcc48.rb:27:in `<class:Gcc48>'
Please report this to the boxen/brews tap!
If reporting this issue please do so at (not Homebrew/brew or Homebrew/core):
  boxen/brews

I saw a related issue #96, but it doesn't seem like all of them were covered. Apparently I have gcc48 installed, and so brew doctor is mad about it. Thanks!

@pelegb
Copy link

pelegb commented Dec 20, 2016

+1

@jacobbednarz
Copy link
Member

Thanks for the report! I'm happy to accept a PR for this against boxen/puppet-gcc if either of you would like to take a crack at it.

@pelegb
Copy link

pelegb commented Dec 21, 2016

@jacobbednarz If I understand correctly this is already fixed. You only need to create a new release.
Can you provide some guidance, if I misunderstood?

Thanks

@jacobbednarz
Copy link
Member

@pelegb errm, kind of? boxen/puppet-gcc now only ships with gcc5 since boxen/puppet-gcc#16. gcc4* should no longer be a thing.

I'm not sure about needing a new release since 3.0.2 from the releases seems to be matching master in that repository. boxen/our-boxen has this at the latest version too.

Are you just missing these updates from your forks?

@eugeneius
Copy link

I ran into this problem too, and I'm using the latest version of the puppet-gcc module.

I manually uninstalled the offending packages as a workaround:

brew uninstall apple-gcc42 gcc48

Even though they're no longer installed since boxen/puppet-gcc#16, those other gcc packages will still be present on any machine that ever ran Boxen with a previous version of the module. We should probably uninstall them automatically if they're present.

@jacobbednarz
Copy link
Member

perhaps we can open a PR with the following instead?

package { ['apple-gcc42', 'gcc48']:
  ensure => absent
}

@eugeneius
Copy link

Yeah sorry, that's what I meant by "uninstall them automatically" - not shelling out to run the brew command 😬

@dkowis @pelegb do either of you want to try fixing the module with that approach? ☝️

@dkowis
Copy link
Author

dkowis commented Jan 3, 2017

I'll do it.

@jacobbednarz
Copy link
Member

Awesome, I'll close this one off and we'll discuss the change in the correct repository.

Thanks everyone!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

4 participants