feat(file-icon): Adding AdobeExpress icon to FileIcon #3894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-in-a-box
requested changes
Feb 5, 2025
src/icons/file-icon/FileIcon.tsx
Outdated
| @@ -34,6 +34,7 @@ import { | |||
| FileXbd, | |||
| FileXdw, | |||
| FileZip, | |||
| FileAdobeExpress, | |||
There was a problem hiding this comment.
this should be alphabetize
| @@ -83,6 +85,7 @@ const mirror = (values: Array<string>) => | |||
| }, {}); | |||
|
|
|||
| export const EXTENSIONS: { [key: string]: { [key: string]: string } } = { | |||
| FileAdobeExpress: mirror(['adobeexpress']), | |||
There was a problem hiding this comment.
Can we update the unit test to reflect this extension that was added?
greg-in-a-box
approved these changes
Feb 5, 2025
marcinsikorski-at-box
approved these changes
Feb 7, 2025
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding AdobeExpress file to FileIcon component